fix: ensure Drupal 11.4 compatibility#65
Merged
Merged
Conversation
autosave_form 1.10 passes too few arguments to FormBuilder::__construct(), which gained an 11th parameter in Drupal 11.4. Bumping to ^1.11 fixes the ArgumentCountError that breaks site installation. Drupal 11.4 also pulls in symfony/runtime as a Composer plugin; allow it in the project config so composer install does not abort.
The implicit nullable fix is included upstream in version 2.3.0, which is what ^2.2 now resolves to. The patch no longer applies cleanly and is no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
drupal/autosave_formfrom^1.10to^1.11: version 1.10'sAutosaveFormBuilderpasses 10 arguments toFormBuilder::__construct(), but Drupal 11.4 added an 11th parameter, causing anArgumentCountErrorthat crashes site installation during thescheduler_content_moderation_integrationinstall hook.symfony/runtimeComposer plugin: Drupal 11.4 introducessymfony/runtimeas a dependency; without this allowlist entry,composer installaborts.Test plan
drush site:install dxpr_cms_installercompletes successfully on Drupal 11.4.0ddev-install.ymlGitHub Action will confirm the fix on CI (it runs a from-scratch install)