ci: make workflows consistent with justfile, check uv.lock in recipes by Copilot · Pull Request #115 · dwilding/gimmegit

Copilot · 2026-04-18T11:58:10Z

This PR makes several adjustments to the GitHub workflows and development commands (in justfile) for consistency and predictability.

Agent-Logs-Url: https://github.com/dwilding/gimmegit/sessions/e0a8a3ec-de14-447a-aecb-c240efbb8f0f Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>

Agent-Logs-Url: https://github.com/dwilding/gimmegit/sessions/48579cd4-2f55-4193-bc4e-30f80e1e87f3 Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>

Agent-Logs-Url: https://github.com/dwilding/gimmegit/sessions/9b5175d1-7644-4588-8ad7-4f59eef31156 Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>

dwilding

For the command reference check in the justfile, let's not use --locked. This should be a standalone script that ignores the locked dependencies. So I think --no-project would be appropriate. But please research whether --script would be even better (does it imply --no-project?). Please use whichever approach you find to be most suitable.

Agent-Logs-Url: https://github.com/dwilding/gimmegit/sessions/279f1679-9813-47db-b9e7-bfe9a85c7212 Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>

Copilot · 2026-04-18T14:40:41Z

For the command reference check in the justfile, let's not use --locked. This should be a standalone script that ignores the locked dependencies. So I think --no-project would be appropriate. But plea...

--script does imply --no-project — it treats the file as a PEP 723 standalone script and doesn't consult the project's pyproject.toml at all. So I've used --script for extract_command_reference.py and --no-project for gimmegit -h (since that's a tool invocation, not a script). Commit c8ee793.

dwilding

You wrote:

... and --no-project for gimmegit -h (since that's a tool invocation, not a script)

But gimmegit is our tool. We ought to be running this with our dependencies.

Agent-Logs-Url: https://github.com/dwilding/gimmegit/sessions/94b074e8-0574-4ee6-b8e7-37e3a4d70d30 Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>

Copilot · 2026-04-18T14:45:53Z

You wrote:

... and --no-project for gimmegit -h (since that's a tool invocation, not a script)...

Fixed in d2adf07 — gimmegit -h now uses --locked again.

dwilding

Let's align the zizmor workflow with zizmor in the justfile. Use the workflow in the justfile, so that the workflow can call the justfile recipe (similarly to other workflows). Let's also rename the output file to workflows.sarif. Don't forget to gitignore this file.

…rkflows.sarif Agent-Logs-Url: https://github.com/dwilding/gimmegit/sessions/9bf26cb2-2ede-422d-bc4e-03f97d261d7d Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>

Copilot · 2026-04-18T14:56:18Z

Let's align the zizmor workflow with zizmor in the justfile. Use the workflow in the justfile, so that the workflow can call the justfile recipe (similarly to other workflows). Let's also rename the o...

Done in 36a3995. The zizmor justfile recipe now runs uv run --locked zizmor --format=sarif . > workflows.sarif, zizmor.yaml calls uvx --from rust-just just zizmor (consistent with other workflows), and workflows.sarif is added to .gitignore.

dwilding

Please review whether pre-commit config needs updating after the justfile naming change. Are there any other call sites to the justfile that need changing?

Agent-Logs-Url: https://github.com/dwilding/gimmegit/sessions/a93a08b4-a24b-41e3-992f-6f9b6a19a025 Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>

Copilot · 2026-04-18T15:03:29Z

Please review whether pre-commit config needs updating after the justfile naming change. Are there any other call sites to the justfile that need changing?

.pre-commit-config.yaml still referenced just check-command-reference — updated to just command-reference in fa2154c. The README only has an anchor link to the "Command reference" section heading (unrelated to the justfile recipe name), so no change needed there.

Agent-Logs-Url: https://github.com/dwilding/gimmegit/sessions/164080e9-0e34-48bf-86a6-aaf8474114d0 Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>

dwilding

I think it's too noisy to have --locked everywhere in the justfile. Let's adjust the apporach. Instead, as the first step in all relevant recipes, please include uv lock --check.

…ecipes Agent-Logs-Url: https://github.com/dwilding/gimmegit/sessions/417a5b42-55d8-49ce-b644-35d250d88062 Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>

Copilot · 2026-04-18T22:54:40Z

I think it's too noisy to have --locked everywhere in the justfile. Let's adjust the apporach. Instead, as the first step in all relevant recipes, please include uv lock --check.

Done in d365bdb. All relevant recipes (format, lint, test, zizmor, command-reference, demo) now start with uv lock --check, and --locked has been removed from all uv run calls.

…s from pre-commit hooks Agent-Logs-Url: https://github.com/dwilding/gimmegit/sessions/1604aa7e-46cc-4dd6-ac2a-d2ddf9dcb00f Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>

Copilot

Pull request overview

This PR splits the “command reference” verification into its own GitHub Actions workflow, renames the related just recipe, and aligns the zizmor workflow to invoke just consistently while standardizing the SARIF output filename.

Changes:

Rename just recipe check-command-reference → command-ref and update consumers (pre-commit + new workflow).
Add a dedicated .github/workflows/command-reference.yaml workflow and simplify lint.yaml accordingly.
Update zizmor to generate workflows.sarif via the justfile recipe, upload that SARIF in CI, and ignore the file in git.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`justfile`	Adds `uv lock --check`, renames the command reference recipe, and standardizes `zizmor` SARIF output to `workflows.sarif`.
`.pre-commit-config.yaml`	Updates local hook to call `just command-ref` and removes optional `name` fields.
`.gitignore`	Ignores generated `workflows.sarif`.
`.github/workflows/zizmor.yaml`	Switches to running `zizmor` via `uvx … just zizmor` and uploads `workflows.sarif`.
`.github/workflows/lint.yaml`	Renames the workflow/job and removes the command reference step (now separate workflow).
`.github/workflows/command-reference.yaml`	Adds a new workflow to run the `command-ref` check on PRs and main pushes.

dwilding

Please rename command-reference.yaml to command-ref.yaml. Please also rename the corresponding python script to use ref instead of reference in the name.

Agent-Logs-Url: https://github.com/dwilding/gimmegit/sessions/b49e60dd-c9cf-41af-8297-b8102f9ed365 Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>

Copilot · 2026-04-18T23:20:37Z

Please rename command-reference.yaml to command-ref.yaml. Please also rename the corresponding python script to use ref instead of reference in the name.

Done in 1d7ba64 — renamed command-reference.yaml → command-ref.yaml and extract_command_reference.py → extract_command_ref.py.

Copilot AI and others added 3 commits April 18, 2026 11:42

Remove CI uv.lock check and enforce uv run --locked in justfile

932a8c4

Agent-Logs-Url: https://github.com/dwilding/gimmegit/sessions/e0a8a3ec-de14-447a-aecb-c240efbb8f0f Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>

Split checks.yaml into lint.yaml and command-reference.yaml

8652771

Agent-Logs-Url: https://github.com/dwilding/gimmegit/sessions/48579cd4-2f55-4193-bc4e-30f80e1e87f3 Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>

Rename justfile command check-command-reference to command-reference

c6d8e0c

Agent-Logs-Url: https://github.com/dwilding/gimmegit/sessions/9b5175d1-7644-4588-8ad7-4f59eef31156 Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>

Copilot AI assigned Copilot and dwilding Apr 18, 2026

Copilot created this pull request from a session on behalf of dwilding April 18, 2026 11:58 View session

dwilding requested changes Apr 18, 2026

View reviewed changes

Copilot started work on behalf of dwilding April 18, 2026 14:39 View session

Use --script and --no-project in command-reference justfile command

c8ee793

Agent-Logs-Url: https://github.com/dwilding/gimmegit/sessions/279f1679-9813-47db-b9e7-bfe9a85c7212 Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>

Copilot AI requested a review from dwilding April 18, 2026 14:41

Copilot finished work on behalf of dwilding April 18, 2026 14:41

dwilding requested changes Apr 18, 2026

View reviewed changes

Copilot started work on behalf of dwilding April 18, 2026 14:45 View session

Run gimmegit with --locked in command-reference justfile command

d2adf07

Agent-Logs-Url: https://github.com/dwilding/gimmegit/sessions/94b074e8-0574-4ee6-b8e7-37e3a4d70d30 Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>

Copilot AI requested a review from dwilding April 18, 2026 14:46

Copilot finished work on behalf of dwilding April 18, 2026 14:46

dwilding requested changes Apr 18, 2026

View reviewed changes

Copilot started work on behalf of dwilding April 18, 2026 14:55 View session

Align zizmor workflow with justfile recipe, rename SARIF output to wo…

36a3995

…rkflows.sarif Agent-Logs-Url: https://github.com/dwilding/gimmegit/sessions/9bf26cb2-2ede-422d-bc4e-03f97d261d7d Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>

Copilot AI changed the title ~~Split checks workflow and rename justfile command~~ Split checks workflow, rename justfile command, and align zizmor workflow Apr 18, 2026

Copilot AI requested a review from dwilding April 18, 2026 14:56

Copilot finished work on behalf of dwilding April 18, 2026 14:56

dwilding requested changes Apr 18, 2026

View reviewed changes

Copilot started work on behalf of dwilding April 18, 2026 15:02 View session

Update pre-commit config to use renamed command-reference recipe

fa2154c

Agent-Logs-Url: https://github.com/dwilding/gimmegit/sessions/a93a08b4-a24b-41e3-992f-6f9b6a19a025 Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>

Copilot finished work on behalf of dwilding April 18, 2026 15:04

Copilot started work on behalf of dwilding April 18, 2026 15:26 View session

Rename workflow to "Check command reference"

7a2f5af

Agent-Logs-Url: https://github.com/dwilding/gimmegit/sessions/164080e9-0e34-48bf-86a6-aaf8474114d0 Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>

Copilot AI requested a review from dwilding April 18, 2026 15:28

Copilot finished work on behalf of dwilding April 18, 2026 15:28

dwilding requested changes Apr 18, 2026

View reviewed changes

Copilot started work on behalf of dwilding April 18, 2026 22:53 View session

Replace --locked with uv lock --check as first step in all relevant r…

d365bdb

…ecipes Agent-Logs-Url: https://github.com/dwilding/gimmegit/sessions/417a5b42-55d8-49ce-b644-35d250d88062 Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>

Copilot finished work on behalf of dwilding April 18, 2026 22:55

Copilot AI requested a review from dwilding April 18, 2026 22:55

dwilding requested changes Apr 18, 2026

View reviewed changes

Comment thread .github/workflows/command-reference.yaml Outdated

Comment thread .pre-commit-config.yaml Outdated

Copilot started work on behalf of dwilding April 18, 2026 23:01 View session

Rename command-reference identifier to command-ref, remove name field…

9f70f1a

…s from pre-commit hooks Agent-Logs-Url: https://github.com/dwilding/gimmegit/sessions/1604aa7e-46cc-4dd6-ac2a-d2ddf9dcb00f Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>

Copilot finished work on behalf of dwilding April 18, 2026 23:03

Copilot AI requested a review from dwilding April 18, 2026 23:03

dwilding approved these changes Apr 18, 2026

View reviewed changes

dwilding marked this pull request as ready for review April 18, 2026 23:04

Copilot AI review requested due to automatic review settings April 18, 2026 23:04

Copilot started reviewing on behalf of dwilding April 18, 2026 23:05 View session

Copilot AI reviewed Apr 18, 2026

View reviewed changes

Comment thread justfile

Comment thread justfile Outdated

dwilding requested changes Apr 18, 2026

View reviewed changes

Comment thread justfile

Comment thread justfile Outdated

Copilot started work on behalf of dwilding April 18, 2026 23:19 View session

Add set -e to shebang recipes, rename workflow and script to use ref

1d7ba64

Agent-Logs-Url: https://github.com/dwilding/gimmegit/sessions/b49e60dd-c9cf-41af-8297-b8102f9ed365 Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>

Copilot AI requested a review from dwilding April 18, 2026 23:21

Copilot finished work on behalf of dwilding April 18, 2026 23:21

dwilding changed the title ~~Split checks workflow, rename justfile command, and align zizmor workflow~~ ci: make workflows consistent with justfile, check uv.lock in recipes Apr 18, 2026

dwilding approved these changes Apr 18, 2026

View reviewed changes

dwilding merged commit b90f616 into main Apr 18, 2026
12 checks passed

dwilding deleted the copilot/update-justfile-to-use-uv-locked branch April 18, 2026 23:30

Conversation

Copilot AI commented Apr 18, 2026 • edited by dwilding Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dwilding left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Apr 18, 2026

Uh oh!

dwilding left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Apr 18, 2026

Uh oh!

dwilding left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Apr 18, 2026

Uh oh!

dwilding left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Apr 18, 2026

Uh oh!

dwilding left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Apr 18, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

dwilding left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Apr 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 18, 2026 •

edited by dwilding

Loading