fix: sign in#1890
Open
sr4850 wants to merge 8 commits into
Open
Conversation
Added handling for 'You have already proved your identity' and 'Confirm your details' pages at the end of signInGovAccount() so all callers benefit. Also added handling in operator countersigns steps in TmVerifyDifferentOperator. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…count The 'Confirm your details' page appears before 'Continue to the service' button check. Since that check triggers an early return when the button isn't found, the handling at the end was never reached. Moved the checks to before the early return point. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…Operator Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issue: JIRA_TICKET_NUMBER
Before submitting (or marking as "ready for review")