Skip to content

fix: vol 5427 certificate of roadworthiness vrm bug#311

Merged
ilindsay merged 1 commit into
mainfrom
vol-5427-certificate-roadworthiness-vrn-error-bug
May 26, 2026
Merged

fix: vol 5427 certificate of roadworthiness vrm bug#311
ilindsay merged 1 commit into
mainfrom
vol-5427-certificate-roadworthiness-vrn-error-bug

Conversation

@waheeduk
Copy link
Copy Markdown
Contributor

@waheeduk waheeduk commented May 26, 2026

Description

Lowercase vehicle registration numbers were being rejected on the certificate of roadworthiness VRN step despite a filter (Dvsa\Olcs\Transfer\Filter\Vrm) already existing to uppercase input before validation.
The filter was never being attached because the validator rule string returned by the backend includes a leading backslash (\Dvsa\Olcs\Transfer\Validators\Vrm), while ::class resolves without one, causing the equality check in ValidatorsAdder::add() to always fail silently.
Fixed by trimming the leading backslash before comparison.

Related issue: VOL-5427

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@waheeduk waheeduk requested a review from ilindsay as a code owner May 26, 2026 09:44
@ilindsay ilindsay merged commit d5e941d into main May 26, 2026
12 checks passed
@ilindsay ilindsay deleted the vol-5427-certificate-roadworthiness-vrn-error-bug branch May 26, 2026 14:53
@ilindsay ilindsay changed the title fix: vol 5427 certificate of roadworthiness von bug fix: vol 5427 certificate of roadworthiness vrm bug May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants