Add InstantEx trait to support std::time::Instant operations. - #4
Open
osamasalem wants to merge 1 commit into
Open
Add InstantEx trait to support std::time::Instant operations.#4osamasalem wants to merge 1 commit into
osamasalem wants to merge 1 commit into
Conversation
|
I think you could add some documentation about when to expect a runtime panic. |
Owner
|
Nice suggestion i will take a look at it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there 👋
I just added a couple of functions to the repo to support
std::time::Instantoperations, it is not my idea, we credit DHH for !! 😄it is something like
So it returns an instant from 5 secs before
now()Let me know if anything else needed from this PR
Thansks