Refactor animatePlayerMoveGeneric to delegate logic to game.execute_move()

[Copilot]

Eliminates code duplication between UI layer (animatePlayerMoveGeneric) and game engine (execute_move). Previously, aggravation logic was independently implemented in both locations, creating maintenance burden and potential for inconsistency between GUI and headless modes.

Changes

• Centralized game logic: animatePlayerMoveGeneric now calls game.execute_move() upfront for all move logic including aggravation detection
• Removed duplicate code: Deleted direct calls to find_marble_at_position() and send_marble_home() from UI layer
• Animation driven by result: Aggravation animation triggered by move_result['aggravated_opponent'] flag instead of redundant detection
• Consistency check: Added validation to ensure animation position matches execute_move calculation

Before

# UI layer duplicated aggravation logic
opponent = game.find_marble_at_position(final_pos)
if opponent is not None and opponent[0] != player:
    opp_player, opp_marble_idx = opponent
    opp_old_pos = game.send_marble_home(opp_player, opp_marble_idx)

After

# Single source of truth in game engine
move_result = game.execute_move(player, marble_idx, moves)
if move_result['aggravated_opponent']:
    agg_info = move_result['aggravated_info']
    # Use result to drive animation only

This establishes execute_move() as the single source of truth for game rules, ensuring GUI and headless simulation remain in sync.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.