Fix Escape cancel on pre-record toolbar#299
Conversation
|
Hey @rv4no, Thanks for your effort. I've been testing the improvement of this PR. First of all, I can't press interacting pre-record toolbar anymore |
|
@duongductrong Good catch. I had mainly tested the app/window selection path, where this did not reproduce. The issue was in manual region selection: the crop overlay and pre-record toolbar coexist, and the overlay could keep stealing interaction/focus. Updated the fix so the toolbar reliably receives clicks/Escape, re-fronts after overlay creation, and pre-record cancel cleans up immediately when idle. Added focused regression tests for toolbar clickability/window style and Escape cancel. |
|
Updated: Current fix is still a bit shaky. So I'll keep it draft for now. The root issue is that the pre-record toolbar can be visible but not actually key/frontmost after area selection, because the previously active app may regain focus. That makes Esc unreliable and can also cause the first click on the toolbar to miss. |
Summary
Verification