Don't mkdir() on construction#12
Open
tarnfeld wants to merge 2 commits into
Open
Conversation
This was a cheap hack, basically the issue here is that you could be opening the filesystem for read access only, and you don't have permission to write. So the mkdir will fail, or do things you don't want (like create the directory with the wrong perms).
|
LGTM 👍 |
Contributor
|
(Code untested.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a cheap hack, basically the issue here is that you could be opening the filesystem for read access only, and you don't have permission to write. So the mkdir will fail, or do things you don't want (like create the directory with the wrong perms).