Skip to content

resize and reposition waving Dax on NTP#8673

Merged
LukasPaczos merged 1 commit into
developfrom
fix/lpaczos/brand-design-onboarding/resize-dax-on-ntp
May 25, 2026
Merged

resize and reposition waving Dax on NTP#8673
LukasPaczos merged 1 commit into
developfrom
fix/lpaczos/brand-design-onboarding/resize-dax-on-ntp

Conversation

@LukasPaczos
Copy link
Copy Markdown
Contributor

@LukasPaczos LukasPaczos commented May 22, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/project/1142021229838617/task/1215060119809247?focus=true

Description

Sets different sizes/offsets for waving Dax CTAs on NTP.

Steps to test this PR

  • Apply this diff:
diff --git a/app/src/main/java/com/duckduckgo/app/cta/ui/CtaViewModel.kt b/app/src/main/java/com/duckduckgo/app/cta/ui/CtaViewModel.kt
index d23642060b..aed162eba1 100644
--- a/app/src/main/java/com/duckduckgo/app/cta/ui/CtaViewModel.kt
+++ b/app/src/main/java/com/duckduckgo/app/cta/ui/CtaViewModel.kt
@@ -113,7 +113,7 @@ class CtaViewModel @Inject constructor(
             }
 
     private suspend fun isSubscriptionCtaAvailable(): Boolean =
-        subscriptions.isEligible() && hasNoSubscription() && extendedOnboardingFeatureToggles.privacyProCta().isEnabled()
+        true
 
     private suspend fun isBrandDesignUpdateEnabled(): Boolean = withContext(dispatchers.io()) {
         onboardingBrandDesignUpdateToggles.brandDesignUpdate().isEnabled()
  • Clean install the app.
  • Go through linear onboarding.
  • Once you reach try-a-search context dialog
  • Go to tab switcher and re-open NTP.
  • Verify that try-a-site dialog is visible and waving Dax is in the bottom left corner.
    • On a tablet - verify that dax is aligned with the left edge of the dialog.
  • Close the dialog.
  • Go to tab switcher and re-open NTP.
  • Verify that high-five dialog is visible and waving Dax is in the bottom left corner, larger than previously.
    • On a tablet - verify that dax is aligned with the left edge of the dialog.
  • Click the primary button.
  • Verify that subscription dialog is visible and waving Dax is peeking from the left edge, even larger than previously.

UI changes

Before After
image image
image image

Note

Low Risk
Low risk UI-only changes that adjust Lottie positioning/sizing for onboarding CTAs; primary risk is visual regressions across phone/tablet form factors.

Overview
Standardizes waving Dax configuration for brand-design bubble CTAs by introducing a WavingDaxSpec (rotation, x/y offsets, height, and tablet anchoring) and updating configureWavingDax to apply those values.

Updates the visit-site, end, and subscription brand-design CTAs to supply their own specs (including a larger/offset subscription Dax) and removes hardcoded translation values from the shared layout XML. Adds/updates unit tests to cover rotation reset and tablet/parent anchoring behavior.

Reviewed by Cursor Bugbot for commit 50af91d. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor

@catalinradoiu catalinradoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@LukasPaczos LukasPaczos merged commit 460cd38 into develop May 25, 2026
34 checks passed
@LukasPaczos LukasPaczos deleted the fix/lpaczos/brand-design-onboarding/resize-dax-on-ntp branch May 25, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants