resize and reposition waving Dax on NTP#8673
Merged
LukasPaczos merged 1 commit intoMay 25, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1142021229838617/task/1215060119809247?focus=true
Description
Sets different sizes/offsets for waving Dax CTAs on NTP.
Steps to test this PR
UI changes
Note
Low Risk
Low risk UI-only changes that adjust Lottie positioning/sizing for onboarding CTAs; primary risk is visual regressions across phone/tablet form factors.
Overview
Standardizes waving Dax configuration for brand-design bubble CTAs by introducing a
WavingDaxSpec(rotation, x/y offsets, height, and tablet anchoring) and updatingconfigureWavingDaxto apply those values.Updates the visit-site, end, and subscription brand-design CTAs to supply their own specs (including a larger/offset subscription Dax) and removes hardcoded translation values from the shared layout XML. Adds/updates unit tests to cover rotation reset and tablet/parent anchoring behavior.
Reviewed by Cursor Bugbot for commit 50af91d. Bugbot is set up for automated code reviews on this repo. Configure here.