Add pixel events for Quick Setup onboarding screen#8672
Open
catalinradoiu wants to merge 4 commits into
Open
Conversation
Fires m_onboarding_quick-setup with e=shown when the Quick Setup dialog is displayed and with e=clicked on the Start browsing CTA, following the new Onboarding Instrumentation Standard params (it, d, source, flow, pixelSource). The clicked event includes a composite value param capturing the user's configuration (set_as_default, widget, address_bar, input_type). Task/Issue URL: https://app.asana.com/1/137249556945/project/1211724162604201/task/1214680037502327
9 tasks
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
18 tasks
Adds a schema entry for the new Quick Setup onboarding pixel under PixelDefinitions/pixels/definitions/onboarding.json5, declaring its parameters (e, it, d, source, flow, pixelSource, value) and the form_factor suffix used by other onboarding pixels. Task/Issue URL: https://app.asana.com/1/137249556945/project/1211724162604201/task/1214680037502327
Switches the composite value parameter of m_onboarding_quick-setup (e=clicked) from space- to comma-separated pairs for cleaner URL encoding and easier reading in dashboards. Task/Issue URL: https://app.asana.com/1/137249556945/project/1211724162604201/task/1214680037502327
Contributor
|
Privacy Review task: https://app.asana.com/0/69071770703008/1215061445765251 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 694790e. Configure here.
Registers ONBOARDING_QUICK_SETUP in PixelParamRemovalInterceptor with removeAtb() so the runtime-appended atb parameter does not violate the pixel's declared param set during triage. Matches the existing pattern for sibling onboarding pixels (PREONBOARDING_INTRO_REINSTALL_USER_SHOWN_UNIQUE, PREONBOARDING_SKIP_ONBOARDING_SHOWN_UNIQUE, etc.). Task/Issue URL: https://app.asana.com/1/137249556945/project/1211724162604201/task/1214680037502327
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1211724162604201/task/1214680037502327
Description
Adds two pixel events for the Quick Setup onboarding screen, both using the shared pixel name
m_onboarding_quick-setupand the new Onboarding Instrumentation Standard params (it,d,source,flow,pixelSource):e=shownfires once when the Quick Setup dialog is displayed.e=clickedfires once when the user taps the "Start browsing" CTA, with an additionalvalueparameter encoding the user's selections:set_as_default:on|off widget:on|off address_bar:top|bottom|split input_type:search|search_and_duckai.Both pixels are sent as
Unique(one per user) with distinct tags so the shown and clicked variants don't suppress each other. The day-since-install param (d) is omitted when the user is more than 28 days post-install, per the standard.Steps to test this PR
Quick Setup pixel events
m_onboarding_quick-setuppixel fires withe=shown,it=reinstall,source=default,flow=default,pixelSource=phone(ortableton tablets), anddset to the days-since-install value (0–28).m_onboarding_quick-setuppixel fires withe=clickedand the same standard params, plus avaluestring that reflects the final selections (e.g.set_as_default:on,widget:off,address_bar:bottom,input_type:search).UI changes
Note
Low Risk
Adds new onboarding telemetry for the Quick Setup screen, including new parameters and a composite
valuestring; risk is low as it doesn’t change user-facing flow beyond extra pixel firing and a new DI dependency (DeviceInfo).Overview
Adds a new
m_onboarding_quick-setuppixel definition andAppPixelName.ONBOARDING_QUICK_SETUP, using the onboarding instrumentation standard params (it, optionald,source,flow,pixelSource) and an optional compositevaluefor selections.Updates
BrandDesignUpdatePageViewModelto fire Unique Quick Setup pixels on screen shown and Start browsing clicked (with separate tags so they don’t suppress each other), including encoding default-browser/widget/address-bar/input-type choices, and wires the pixel intoPixelParamRemovalInterceptorfor ATB stripping. Adds targeted unit tests covering param formation (including omittingdafter 28 days) and phone/tablet form factor.Reviewed by Cursor Bugbot for commit dfb371d. Bugbot is set up for automated code reviews on this repo. Configure here.