Skip to content

show wing on in-context fire CTA#8671

Merged
LukasPaczos merged 1 commit into
developfrom
fix/lpaczos/brand-design-onboarding/show-wing-on-fire-cta
May 25, 2026
Merged

show wing on in-context fire CTA#8671
LukasPaczos merged 1 commit into
developfrom
fix/lpaczos/brand-design-onboarding/show-wing-on-fire-cta

Conversation

@LukasPaczos
Copy link
Copy Markdown
Contributor

@LukasPaczos LukasPaczos commented May 22, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/task/1215047349987939

Description

Adds Dax wing animation to Fire CTA.

Steps to test this PR

  • Apply this patch:
diff --git a/app/src/main/java/com/duckduckgo/app/onboardingbranddesignupdate/OnboardingBrandDesignUpdateToggles.kt b/app/src/main/java/com/duckduckgo/app/onboardingbranddesignupdate/OnboardingBrandDesignUpdateToggles.kt
index aebae533d6..df1920652e 100644
--- a/app/src/main/java/com/duckduckgo/app/onboardingbranddesignupdate/OnboardingBrandDesignUpdateToggles.kt
+++ b/app/src/main/java/com/duckduckgo/app/onboardingbranddesignupdate/OnboardingBrandDesignUpdateToggles.kt
@@ -27,16 +27,16 @@ import com.duckduckgo.feature.toggles.api.Toggle.DefaultFeatureValue
 )
 interface OnboardingBrandDesignUpdateToggles {
 
-    @Toggle.DefaultValue(DefaultFeatureValue.INTERNAL)
+    @Toggle.DefaultValue(DefaultFeatureValue.TRUE)
     fun self(): Toggle
 
-    @Toggle.DefaultValue(DefaultFeatureValue.INTERNAL)
+    @Toggle.DefaultValue(DefaultFeatureValue.TRUE)
     fun brandDesignUpdate(): Toggle
 
     /**
      * Gates the new fire animation work: new Inferno default in Data Clearing
      * settings + bottom-sheet Lottie swap.
      */
-    @Toggle.DefaultValue(DefaultFeatureValue.INTERNAL)
+    @Toggle.DefaultValue(DefaultFeatureValue.TRUE)
     fun fireAnimationUpdate(): Toggle
 }
  • Clean install the app.
  • Go through onboarding until you reach the Fire CTA.
  • Verify that:
    • Dax wing is visible.
    • It didn't re-animate when transitioning from the previous CTA.
    • When orientation changes to landscape, the wing is gone.
    • When orientation changes back to portrait, the wing appears without any transition.

UI changes

Before After
image image

Note

Medium Risk
Moderate risk because it changes CTA animation state management and relies on Lottie frame/progress behavior, which can be device/composition dependent and affect visual stability across CTA transitions/orientation changes.

Overview
Shows the Dax wing on the brand-design contextual Fire CTA by marking DaxFireButtonBrandDesignUpdateContextualCta as ShowsWingBottom.

Refines wing persistence logic during CTA transitions: when a wing CTA arrives and the wing is already visible, it now always snaps to the resting state and cancels any in-flight animator to prevent unwanted replays or being hidden by previous end-listeners.

Fixes wing play-in gating by switching from progress comparisons to frame-based checks (wing.frame/maxFrame) to avoid precision/rounding edge cases in Lottie that could prevent the play-in from triggering. Updates unit tests to cover these scenarios.

Reviewed by Cursor Bugbot for commit 4d7c486. Bugbot is set up for automated code reviews on this repo. Configure here.

@LukasPaczos LukasPaczos force-pushed the fix/lpaczos/brand-design-onboarding/show-wing-on-fire-cta branch from 759f537 to 4d7c486 Compare May 22, 2026 15:22
Copy link
Copy Markdown
Contributor

@catalinradoiu catalinradoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected. 👍

@LukasPaczos LukasPaczos merged commit 4a3ba3c into develop May 25, 2026
25 checks passed
@LukasPaczos LukasPaczos deleted the fix/lpaczos/brand-design-onboarding/show-wing-on-fire-cta branch May 25, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants