show wing on in-context fire CTA#8671
Merged
LukasPaczos merged 1 commit intoMay 25, 2026
Merged
Conversation
759f537 to
4d7c486
Compare
catalinradoiu
approved these changes
May 25, 2026
Contributor
catalinradoiu
left a comment
There was a problem hiding this comment.
Looks good and works as expected. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/task/1215047349987939
Description
Adds Dax wing animation to Fire CTA.
Steps to test this PR
UI changes
Note
Medium Risk
Moderate risk because it changes CTA animation state management and relies on Lottie frame/progress behavior, which can be device/composition dependent and affect visual stability across CTA transitions/orientation changes.
Overview
Shows the Dax wing on the brand-design contextual Fire CTA by marking
DaxFireButtonBrandDesignUpdateContextualCtaasShowsWingBottom.Refines wing persistence logic during CTA transitions: when a wing CTA arrives and the wing is already visible, it now always snaps to the resting state and cancels any in-flight animator to prevent unwanted replays or being hidden by previous end-listeners.
Fixes wing play-in gating by switching from
progresscomparisons to frame-based checks (wing.frame/maxFrame) to avoid precision/rounding edge cases in Lottie that could prevent the play-in from triggering. Updates unit tests to cover these scenarios.Reviewed by Cursor Bugbot for commit 4d7c486. Bugbot is set up for automated code reviews on this repo. Configure here.