Don't fire metrics pixels when toggle is disabled#8661
Open
catalinradoiu wants to merge 1 commit into
Open
Conversation
RealMetricsPixelSender previously fired metrics pixels regardless of whether the underlying experiment toggle was enabled — as long as the cohort was assigned and the conversion window matched. This meant metrics could continue to be sent for experiments that had been remotely turned off. Short-circuit send() when the toggle is disabled. Task: https://app.asana.com/1/137249556945/project/1202552961248957/task/1215026841068543
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1202552961248957/task/1215026841068543
Description
RealMetricsPixelSender.send()previously fired metrics pixels without checking whether the underlying experiment toggle was enabled. As long as a cohort was assigned and the conversion window matched, pixels would fire — even if the toggle had been remotely turned off.This adds a short-circuit at the top of
send(): ifmetricsPixel.toggle.isEnabled()returnsfalse, no pixel is fired and (forCOUNT_*types) no count is incremented.Steps to test this PR
Toggle disabled — no pixels fired
UI changes
Note
Low Risk
Low risk: adds a simple enablement gate and accompanying tests; impact is limited to analytics emission/counting when toggles are off.
Overview
Prevents metrics emission when a toggle is off.
RealMetricsPixelSender.sendnow returns immediately ifmetricsPixel.toggle.isEnabled()is false, so pixels and metric counters are not processed for disabled experiments.Test coverage updated to assert that
NORMAL,COUNT_WHEN_IN_WINDOW, andCOUNT_ALWAYSpixels neither fire nor increment stored counts when the toggle is disabled.Reviewed by Cursor Bugbot for commit a1d06cc. Bugbot is set up for automated code reviews on this repo. Configure here.