Skip to content

PIR: Add new email flexibility action models#8232

Open
landomen wants to merge 3 commits into
developfrom
feature/domen/pir-email-flexibility-models
Open

PIR: Add new email flexibility action models#8232
landomen wants to merge 3 commits into
developfrom
feature/domen/pir-email-flexibility-models

Conversation

@landomen
Copy link
Copy Markdown
Contributor

@landomen landomen commented Apr 9, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1213886961787937?focus=true

Description

Adds new models for two new broker actions needed to support email flexibility.

Steps to test this PR

No QA needed, will be testable on later branches

UI changes

No UI changes


Note

Low Risk
Low risk: adds new BrokerAction subtypes and Moshi wiring with minor test fake updates; no core opt-out/scan logic changes.

Overview
Adds two new PIR broker action models, BrokerAction.GenerateEmail and BrokerAction.GetEmailData (including pollingTime and extract fields), and updates asActionType() to emit the new action type strings.

Updates PIR’s Moshi polymorphic adapter configuration in PirModule to deserialize these new actionType values, and extends FakePirMessagingInterface to return success responses for them in integration tests.

Reviewed by Cursor Bugbot for commit 7eb4a04. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f3281cc. Configure here.

Comment thread pir/pir-impl/src/main/java/com/duckduckgo/pir/impl/scripts/models/BrokerAction.kt Outdated
@landomen landomen force-pushed the feature/domen/pir-email-flexibility-models branch from 27c8bc3 to 7eb4a04 Compare May 22, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants