Instead of recomputing log()s of @a, @b, and @pi as needed, this does it...#1
Open
jimlindstrom wants to merge 1 commit into
Open
Instead of recomputing log()s of @a, @b, and @pi as needed, this does it...#1jimlindstrom wants to merge 1 commit into
jimlindstrom wants to merge 1 commit into
Conversation
… it once, lazily. @log_a, @log_b, @log_pi are calculated the first time they're needed. These are also invalidated (then recalculated, as needed) by the various training methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... once, lazily. @log_a, @log_b, @log_pi are calculated the first time they're needed. These are also invalidated (then recalculated, as needed) by the various training methods.
I'm using HMM to estimate the key of a musical phrase, in https://github.com/jimlindstrom/multi_markov_composer/blob/key-detection/lib/note_queue.rb. When repeatedly calling decode() and likelihood() for different sequences, but without retraining, I noticed that log() was being called a LOT. Precalculating the logs makes my usage of HMM about 2x faster.