Correct validator docstrings against observed behavior - #285
Merged
Conversation
lisad
approved these changes
Aug 13, 2026
aaronjae22
force-pushed
the
refactor/validator-dosctring-testing
branch
from
August 14, 2026 17:32
1ab9e59 to
cc3dcb8
Compare
aaronjae22
force-pushed
the
refactor/validator-dosctring-testing
branch
from
August 14, 2026 17:43
cc3dcb8 to
cb01762
Compare
aaronjae22
force-pushed
the
refactor/validator-dosctring-testing
branch
from
August 14, 2026 17:49
cb01762 to
5b00171
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was checked against a real authorize request.
validate_redirect_uridocumented that returning False raises InvalidRedirectURIError and that DOT "renders an error page." which was a bit off. oauthlib raisesMismatchingRedirectURIErrorwhen our validator returns False, and the response is a 400 re-render of oauth2_provider/authorize.html.Also the scope-check note implied DOT owned the authorization-time check when both validate_scopes calls are ours.