refactor: migrate Xtend to Java - com.avaloq.tools.ddk.xtext.generator.test#1418
Merged
joaodinissf merged 1 commit intoJun 16, 2026
Conversation
…r.test Convert XbaseGeneratorFragmentTest from Xtend to idiomatic Java 21, the last .xtend file in the module, and remove the now-unused Xtend build infrastructure (.classpath, .project, build.properties, xtend-gen). Output verified against the freshly built xtend-gen/ ground truth. The @RegisterExtension rule field stays public per the project convention. The Xtend '->' pairs become a small private record (PackageAndRuleName) instead of carrying org.eclipse.xtext.xbase.lib.Pair into the migrated Java, which also removes the need for @SafeVarargs. Behaviour is preserved. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
joaodinissf
force-pushed
the
migrate/xtend-to-java/xtext-generator-test
branch
from
71f5a7e to
e988712
Compare
rubenporras
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrates
XbaseGeneratorFragmentTestfrom Xtend to idiomatic Java 21 — the last.xtendincom.avaloq.tools.ddk.xtext.generator.test— and removes the module's Xtend build infrastructure (.classpath/.project/build.properties/xtend-gen).How
xtend-gen/ground truth.@RegisterExtensionrule field keptpublicper the project convention (programmatic-extension fields can't be private).->pairs are modelled with a smallprivate record PackageAndRuleName(String packageName, String ruleName)rather than carryingorg.eclipse.xtext.xbase.lib.Pair(an Xtend runtime type) into the migrated Java — a record also handles thenullpackage-name cases (Map.entrywould NPE) and removes the need for@SafeVarargs. Noxbase.libreference remains in this file..xtenddeleted and.javaadded in one commit.Local gate green:
compile + checkstyle:check + pmd:check + spotbugs:checkon the module (JUnit tests run in CI).