chore: enable the PMD UnnecessaryImport rule#1383
Merged
joaodinissf merged 1 commit intoJun 1, 2026
Merged
Conversation
Re-enables the previously-excluded UnnecessaryImport rule. Blast radius is zero: `mvn pmd:check` across the whole reactor reports 0 UnnecessaryImport violations on current master. Generated code (src-gen, src-model, xtend-gen) is already excluded from PMD via excludeRoots, so only hand-written src/ is scanned. The "too many false positives after PMD 7" exclusion comment is stale for the current codebase. Catches unused imports in hand-written source going forward (nothing else in CI does — checkstyle has no unused-import rule). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rubenporras
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enables the
UnnecessaryImportPMD rule (previously excluded with "too many false positives after PMD 7").Blast radius: zero.
mvn pmd:checkacross the full reactor reports 0UnnecessaryImportviolations on current master. Generated roots (src-gen,src-model,xtend-gen) are already excluded from PMD, so only hand-writtensrc/is scanned — and it's clean. The exclusion comment is stale.Going forward this catches unused imports in hand-written source (nothing else in CI does — checkstyle has no unused-import rule; it would have caught e.g. the Javadoc-only imports recently cleaned up in the Xtend→Java migrations).
🤖 Generated with Claude Code