docs: clarify copyright-header and ground-truth rules in xtend-to-java skill#1381
Merged
joaodinissf merged 1 commit intoJun 1, 2026
Conversation
…a skill Three ambiguities surfaced while migrating leaf modules with the skill: - The header rule conflicted with "preserve Javadoc exactly / never invent", so the migration kept the source's `/* generated by Xtext */` or `/** */` header instead of the Avaloq banner. Make explicit that the banner REPLACES any source header and that "never invent" covers class/member Javadoc only, not the copyright header. - The hard rule mandates reading `xtend-gen/`, but it is gitignored and absent in a fresh checkout. Add an explicit fallback: build the module to generate it, or read a pre-converted reference branch's `.java` as the equivalent behavioural ground truth. Never write Java from the `.xtend` source alone. - The skill never mentioned `src-gen/` — the MWE2/Xtext-generated `Abstract*` supertypes the migrated class extends/overrides. It is committed (unlike `xtend-gen/`) and is the authoritative source for inherited constructor signatures, real `@Override` targets, and Xtend-inferred return types. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
c4b7fa8 to
09d1adf
Compare
rubenporras
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two clarifications to the xtend-to-java skill, prompted by ambiguities hit while migrating leaf modules:
/* generated by Xtext */stub marker or a/** */Javadoc-style block), and that the "never invent / preserve Javadoc" rule covers class/member Javadoc only — not the copyright header.xtend-gen/is absent: it is gitignored and missing in a fresh checkout. Add an explicit fallback — build the module, or read a pre-converted reference.java— and forbid writing Java from the.xtendsource alone.Docs-only; touches 5 files under
.agents/skills/xtend-to-java/.🤖 Generated with Claude Code