Skip to content

Don't link against crypt on Linux #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wkornewald wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

Don't link against crypt on Linux #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pdfmp/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ fun KotlinNativeTarget.setUpPdfiumCinterop() {
private fun KotlinNativeTarget.setupSharedLib() {
val androidLib = androidArchMap[name]
val pdfiumPath = androidLib ?: name
val targetName = name

binaries {
sharedLib {
Expand All @@ -81,7 +82,11 @@ private fun KotlinNativeTarget.setupSharedLib() {
val binariesModuleDir = project(":pdfium-binaries").projectDir
linkerOpts.add("-L$binariesModuleDir/binaries/$pdfiumPath")
linkerOpts.add("-lpdfium")
if (name.contains("linux")) linkerOpts.add("-lcrypt")

// Without this we'd link against libcrypt.so.1 unnecessarily and that's
// not even available in a flatpak.
// See https://youtrack.jetbrains.com/projects/KT/issues/KT-55643
if (targetName.contains("linux")) linkerOpts.add("-Wl,--as-needed")
}

binaries {
Expand Down
Loading