PR #67 amended to retain praxis#68
Open
JeffreyBroll wants to merge 19 commits into
Open
Conversation
hurt anyone anymore
resolve issues with newish gcc and clang building Quadpack, QuadPack3, xvgifwr2 under newer C standards
drsteve
requested changes
Jul 9, 2026
Comment on lines
-7
to
-16
| double (*f)( double, _qpInfo *); /* The integrand function -- I.e. the function to integrate */ | ||
| _qpInfo *qpInfo; /* Auxilliary information to pass to function (to avoid making globals) */ | ||
| double a; /* Lower Limit of integration. */ | ||
| double b; /* Upper limit of integration. */ | ||
| double epsabs; /* Absolute accuracy requested. */ | ||
| double epsrel; /* Relative accuracy requested. */ | ||
| double *result; /* The desired result. I.e. integral of f() from a to b */ | ||
| double *abserr; /* Estimate of the modulus of the absolute error in the result */ | ||
| int *neval; /* The number of integrand evaluations performed. */ | ||
| int *ier; /* Error flag. An error occurred if ier > 0. See below. */ |
Owner
There was a problem hiding this comment.
We need to preserve the comments somewhere. Doxygen docstring?
Comment on lines
-258
to
-268
| double (*f)( double, _qpInfo *); /* The integrand function -- I.e. the function to integrate */ | ||
| _qpInfo *qpInfo; /* Auxilliary information to pass to function (to avoid making globals) */ | ||
| double a; /* Lower Limit of integration. */ | ||
| double b; /* Upper limit of integration. */ | ||
| double epsabs; /* Absolute accuracy requested. */ | ||
| double epsrel; /* Relative accuracy requested. */ | ||
| int limit; | ||
| double *result; /* The desired result. I.e. integral of f() from a to b */ | ||
| double *abserr; /* Estimate of the modulus of the absolute error in the result */ | ||
| int *neval; /* The number of integrand evaluations performed. */ | ||
| int *ier; /* Error flag. An error occurred if ier > 0. See below. */ |
Owner
There was a problem hiding this comment.
Again, comments need preserving. Doxygen docstring seems like a good spot.
Comment on lines
-1136
to
-1141
| double (*f)( double, _qpInfo *); /* The integrand function -- I.e. the function to integrate */ | ||
| _qpInfo *qpInfo; /* Auxilliary information to pass to function (to avoid making globals) */ | ||
| double a; /* Lower Limit of integration. */ | ||
| double b; /* Upper limit of integration. */ | ||
| double *result; /* The desired result. I.e. integral of f() from a to b */ | ||
| double *abserr; /* Estimate of the modulus of the absolute error in the result */ |
Owner
There was a problem hiding this comment.
And one more on comments to be preserved
Comment on lines
-7
to
-18
| double (*f)( double, _qpInfo *); /* The integrand function -- I.e. the function to integrate */ | ||
| _qpInfo *qpInfo; /* Auxilliary information to pass to function (to avoid making globals) */ | ||
| double a; /* Lower Limit of integration. */ | ||
| double b; /* Upper limit of integration. */ | ||
| int npts2; | ||
| double *points; | ||
| double epsabs; /* Absolute accuracy requested. */ | ||
| double epsrel; /* Relative accuracy requested. */ | ||
| double *result; /* The desired result. I.e. integral of f() from a to b */ | ||
| double *abserr; /* Estimate of the modulus of the absolute error in the result */ | ||
| int *neval; /* The number of integrand evaluations performed. */ | ||
| int *ier; /* Error flag. An error occurred if ier > 0. See below. */ |
Owner
There was a problem hiding this comment.
Comments need preserving. Maybe doxygen docstring?
Comment on lines
-296
to
-309
| double (*f)( double, _qpInfo *); /* The integrand function -- I.e. the function to integrate */ | ||
| _qpInfo *qpInfo; /* Auxilliary information to pass to function (to avoid making globals) */ | ||
| double a; /* Lower Limit of integration. */ | ||
| double b; /* Upper limit of integration. */ | ||
| int npts2; | ||
| double *points; | ||
| double epsabs; /* Absolute accuracy requested. */ | ||
| double epsrel; /* Relative accuracy requested. */ | ||
| int limit; | ||
| double *result; /* The desired result. I.e. integral of f() from a to b */ | ||
| double *abserr; /* Estimate of the modulus of the absolute error in the result */ | ||
| int *neval; /* The number of integrand evaluations performed. */ | ||
| int *ier; /* Error flag. An error occurred if ier > 0. See below. */ | ||
| double *alist; |
Comment on lines
+616
to
+617
| if (i1 != k1) | ||
| b[i1 - 1] = z; |
Comment on lines
+645
to
+646
| for (int i = ur; i >= lr; i--) | ||
| free((char *)(m[i] + lc)); |
Comment on lines
+699
to
+702
| for (j = i1; j <= n; j++) | ||
| v[j][i] = a[i][j] / h; | ||
| for (j = i1; j <= n; j++) | ||
| elmcol(i1, n, j, i, v, v, matmat(i1, n, i, j, a, v)); |
Comment on lines
+704
to
+705
| for (j = i1; j <= n; j++) | ||
| v[i][j] = v[j][i] = 0.0; |
Comment on lines
+789
to
+790
| for (; l <= u; l++) | ||
| a[i][l] += b[j][l] * x; |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few familiar problems popped up when I ran a fresh build with GCC 16.1.1 and "--coverage -g" so I had to bonk a few things back into place