Silence inadvertently loud debug in TraceLine

[drsteve]

TraceLine.c has different Lgm_TraceLine variants, and when used in the mode that adds a new point at exactly Bm there was some unhidden debug output (i.e., debug was never hit if AddBminPoint was FALSE).

This has now been changed to require a VerbosityLevel setting of 2 or higher in the input MagModelInfo structure.

Alongside this a number of formatting changes were made.

• All tabs have been converted to spaces.
• Numerous blank lines have been removed for readability
• Some brackets and code alignment were set for readability

[drsteve]

@JeffreyBroll @mghenderson64
Can you take a quick look at this? 1c6776f is the commit with the functional changes that hide the debug output. The other commits are just minimal cleanup to get cpplint shouting about a lot fewer lines.

[mghenderson64]

This looks good to me. -M

…

________________________________ From: Steve Morley ***@***.***> Sent: Wednesday, May 20, 2026 4:56 PM To: drsteve/LANLGeoMag ***@***.***> Cc: Henderson, Michael Gerard ***@***.***>; Mention ***@***.***> Subject: [EXTERNAL] Re: [drsteve/LANLGeoMag] Silence inadvertently loud debug in TraceLine (PR #66) [https://avatars.githubusercontent.com/u/7684422?s=20&v=4]drsteve left a comment (drsteve/LANLGeoMag#66)<https://urldefense.com/v3/__https://github.com/drsteve/LANLGeoMag/pull/66*issuecomment-4503309013__;Iw!!Bt8fGhp8LhKGRg!FYp3kYzIHGY-qpDuoaiM0ANkLKLnleWpVvdcXHNn4BNLjOOPBSKkkVcFTewBsLDcB2ObmrtSlsn8lxAdgLeN8YOziaQ$> @JeffreyBroll<https://urldefense.com/v3/__https://github.com/JeffreyBroll__;!!Bt8fGhp8LhKGRg!FYp3kYzIHGY-qpDuoaiM0ANkLKLnleWpVvdcXHNn4BNLjOOPBSKkkVcFTewBsLDcB2ObmrtSlsn8lxAdgLeNSB4AHfg$> @mghenderson64<https://urldefense.com/v3/__https://github.com/mghenderson64__;!!Bt8fGhp8LhKGRg!FYp3kYzIHGY-qpDuoaiM0ANkLKLnleWpVvdcXHNn4BNLjOOPBSKkkVcFTewBsLDcB2ObmrtSlsn8lxAdgLeNB_Vs7J0$> Can you take a quick look at this? 1c6776f<https://urldefense.com/v3/__https://github.com/drsteve/LANLGeoMag/commit/1c6776fa91c6337ba9b679e6f10242ca4f2be367__;!!Bt8fGhp8LhKGRg!FYp3kYzIHGY-qpDuoaiM0ANkLKLnleWpVvdcXHNn4BNLjOOPBSKkkVcFTewBsLDcB2ObmrtSlsn8lxAdgLeNnsgNxoY$> is the commit with the functional changes that hide the debug output. The other commits are just minimal cleanup to get cpplint shouting about a lot fewer lines. — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/drsteve/LANLGeoMag/pull/66*issuecomment-4503309013__;Iw!!Bt8fGhp8LhKGRg!FYp3kYzIHGY-qpDuoaiM0ANkLKLnleWpVvdcXHNn4BNLjOOPBSKkkVcFTewBsLDcB2ObmrtSlsn8lxAdgLeN8YOziaQ$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ANFHIQJUXQEEFZZNZX6WDNT43YZY5AVCNFSM6AAAAACZGY534SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DKMBTGMYDSMBRGM__;!!Bt8fGhp8LhKGRg!FYp3kYzIHGY-qpDuoaiM0ANkLKLnleWpVvdcXHNn4BNLjOOPBSKkkVcFTewBsLDcB2ObmrtSlsn8lxAdgLeN1JQ11QA$>. Triage notifications on the go with GitHub Mobile for iOS<https://urldefense.com/v3/__https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!Bt8fGhp8LhKGRg!FYp3kYzIHGY-qpDuoaiM0ANkLKLnleWpVvdcXHNn4BNLjOOPBSKkkVcFTewBsLDcB2ObmrtSlsn8lxAdgLeN65xnAFw$> or Android<https://urldefense.com/v3/__https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign*3Dnotification-email*26utm_medium*3Demail*26utm_source*3Dgithub__;JSUlJSU!!Bt8fGhp8LhKGRg!FYp3kYzIHGY-qpDuoaiM0ANkLKLnleWpVvdcXHNn4BNLjOOPBSKkkVcFTewBsLDcB2ObmrtSlsn8lxAdgLeN4b0UzAg$>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[JeffreyBroll]

Looks good from here.
(1) is it time to have some cpplint turned on in CI as files get cleaned up?
(2) there's a lot of return(-1), a return(-2), and some return(-9...9.9)s. It might be worth filling out bits of an error-y enum before the zoo gets too interesting.

[drsteve]

is it time to have some cpplint turned on in CI as files get cleaned up?

Probably, but I have a stale branch somewhere that was deep into cleanup and it's a huge job, so initially almost every rule and file will be excluded

there's a lot of return(-1), a return(-2), and some return(-9...9.9)s. It might be worth filling out bits of an error-y enum before the zoo gets too interesting.

Believe it or not, I think this is actually better than it used to be. There is an LGM_FILL_VALUE that isn't as widely used as it should be, and there's been some updating of the return over the years to be more consistent. The big issue is making sure that we don't break behavior in the caller for any given return value. It's worth addressing and we should probably open an issue to keep it on the radar.