don't treat numeric properties as string - #2
Open
bevancollins wants to merge 3 commits into
Open
Conversation
Owner
|
Hi @bevancollins! I've updated the master branch to make the tests runnable with node-jasmine. Would you mind adding some new tests for this functionality? |
Contributor
Author
|
Hi @drslump... I'm still coming to terms with git & github. Do I merge your node-jasmine changes to my fork and then add my test? Thanks |
Owner
|
@bevancollins yes, the procedure should be to merge the upstream changes from my repo into your fork. This should be something alongthe following: thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.