Skip to content

don't treat numeric properties as string - #2

Open
bevancollins wants to merge 3 commits into
drslump:masterfrom
bevancollins:master
Open

don't treat numeric properties as string#2
bevancollins wants to merge 3 commits into
drslump:masterfrom
bevancollins:master

Conversation

@bevancollins

Copy link
Copy Markdown
Contributor

No description provided.

@drslump

drslump commented Feb 28, 2014

Copy link
Copy Markdown
Owner

Hi @bevancollins!

I've updated the master branch to make the tests runnable with node-jasmine. Would you mind adding some new tests for this functionality?

npm install
./node_modules/.bin/jasmine-node .

@bevancollins

Copy link
Copy Markdown
Contributor Author

Hi @drslump... I'm still coming to terms with git & github. Do I merge your node-jasmine changes to my fork and then add my test?

Thanks

@drslump

drslump commented Mar 12, 2014

Copy link
Copy Markdown
Owner

@bevancollins yes, the procedure should be to merge the upstream changes from my repo into your fork. This should be something alongthe following:

$ git remote add upstream https://github.com/drslump/Ini-js.git
$ git fetch upstream
$ git merge upstream/master

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants