Enable Excel XMLA drill-through by implementing MDSCHEMA_ACTIONS and fixing HIERARCHY_ORIGIN null safety#3
Closed
Copilot wants to merge 2 commits into
Closed
Conversation
…RIGIN null safety, tests Agent-Logs-Url: https://github.com/dronsv/mondrian/sessions/5db74d19-af65-4da5-ba5a-2c8c10dc0247 Co-authored-by: dronsv <16214327+dronsv@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dronsv/mondrian/sessions/5db74d19-af65-4da5-ba5a-2c8c10dc0247 Co-authored-by: dronsv <16214327+dronsv@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
dronsv
April 1, 2026 18:12
View session
Copilot stopped work on behalf of
dronsv due to an error
April 1, 2026 19:31
Owner
|
Closing — MDSCHEMA_ACTIONS support and DRILLTHROUGH_ACTION_NAME constant are already on main (RowsetDefinition.java:4389+). PR is stale; branch will be deleted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Excel's "Show Details" (drill-through) on XMLA PivotTables was silently disabled because Mondrian returned no rows for
MDSCHEMA_ACTIONS— the discovery request Excel uses to gate the feature. This also adds a null-safety fix for virtual hierarchies inMDSCHEMA_HIERARCHIES.MDSCHEMA_ACTIONS — populate drill-through actions per cube
MdschemaActionsRowset.populateImpl()was a no-op. Now emits oneDrillthroughaction row per visible cube:ACTION_NAME"Drillthrough"ACTION_TYPE256(MDACTION_TYPE_ROWSET)COORDINATE_TYPE1(MDACTION_COORDINATE_CUBE)INVOCATION1(interactive)CUBE_SOURCE1(cube)Three previously stubbed-out columns (
ACTION_TYPE,INVOCATION,CUBE_SOURCE) are now defined and included in the rowset schema. Full restriction filtering (catalog / schema / cube / action name) is wired up viamakeCondition.HIERARCHY_ORIGIN null safety
MdschemaHierarchiesRowsetdereferencedxmlHierarchy.originwithout null-checkingxmlHierarchyitself — a crash path for virtual hierarchies. Now guarded:Test reference XML updates
XmlaBasicTest.ref.xml—testMDActionsresponse now expects 7 action rows (one per FoodMart cube) with the full column schema.XmlaBasicTest.ref.xml,XmlaExcel2000Test.ref.xml,XmlaExcelXPTest.ref.xml—DISCOVER_SCHEMA_ROWSETSentries forMDSCHEMA_ACTIONSupdated to advertise the new restriction columns.Integration tests
Added to
DrillThroughTest:testExcelStyleDrillThroughWithColumnsAndRows— exercises the exact MDX pattern Excel generates (WITHcalculated members,FILTERon both axes,RETURNclause).testDrillThroughWithColumnsAndRowsAxes— baseline check that DRILLTHROUGH with explicitON COLUMNS/ON ROWSreturns rows.