ci: add GitHub Actions workflow (lint, typecheck, test, build) - #8
Merged
Conversation
Runs the four local gates from CLAUDE.md on every pull request and on pushes to master: eslint, tsc (both tsconfigs), vitest, and the full Vite build (asserting dist/manifest.json is produced). Single ubuntu job on Node 22 with npm cache and npm ci; concurrency cancels superseded PR runs; least-privilege read-only token. Unit tests run in Node with no DOM/service-worker/live Fidelity, so CI is a floor, not a replacement for the in-Chrome manual verification CLAUDE.md requires.
Merged
drogers0
added a commit
that referenced
this pull request
Jul 1, 2026
Runs the four local gates from CLAUDE.md on every pull request and on pushes to master: eslint, tsc (both tsconfigs), vitest, and the full Vite build (asserting dist/manifest.json is produced). Single ubuntu job on Node 22 with npm cache and npm ci; concurrency cancels superseded PR runs; least-privilege read-only token. Unit tests run in Node with no DOM/service-worker/live Fidelity, so CI is a floor, not a replacement for the in-Chrome manual verification CLAUDE.md requires.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the repo's first CI. Runs the four gates CLAUDE.md already defines as required, so PRs can't merge red and regressions (like #1) get caught automatically.
Checks (
.github/workflows/ci.yml, jobverify)Ordered cheap → expensive, mirroring the local scripts exactly:
npm run lint(eslint)npm run typecheck(tsc --noEmiton both tsconfigs)npm run test(vitest, 416 tests)npm run build(all 4 Vite configs + manifest/styles copy), thentest -f dist/manifest.jsonto fail loudly if the copy step breaksSetup
pull_request+pushtomaster+workflow_dispatch.npm ciwith npm caching viaactions/setup-node@v4; single job / single install.concurrencycancels a PR's superseded runs;permissions: contents: read(least privilege).Not automated (by design)
Unit tests run in Node with no DOM, service worker, or live Fidelity endpoints. Per CLAUDE.md, green tests are necessary but not sufficient — the in-Chrome manual verification stays a human step. CI is a floor, not a ceiling.
Recommended follow-up (repo setting, not a file)
Enable branch protection on
masterrequiring theverifycheck to pass before merge (Settings → Branches). Happy to walk through it or script it withgh apiif you'd like.