Dockerfile tweaks for singularity support and download url updates#5
Open
javh wants to merge 8 commits into
Open
Dockerfile tweaks for singularity support and download url updates#5javh wants to merge 8 commits into
javh wants to merge 8 commits into
Conversation
droeatumn
approved these changes
Jan 5, 2020
droeatumn
approved these changes
Jan 5, 2020
|
Thank you for the changes. I'm sorry I didn't see them earlier. |
Author
|
Sure thing. Looks like there are some merge conflicts now. I'm planning to pull the new container and see if it works in singularity as-is. Do you want me to update this PR after I do that? |
|
I am deprecating this project. Hopefully, I included your changed in the new repository. |
Author
|
Ah, gotcha. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings,
I made some suggested changes to the Dockerfile to:
/opt/bin/nextflowto 755 so that it can run in an unprivileged environment from within a singularity container.nextflowonce so that its initial setup is performed and preserved in the container (again for singularity support).(I also moved some things around to help me debug. I don't think any of that is important though.)