Stop tests from clobbering the OS clipboard#604
Merged
Conversation
TestCopyStagedClipboard_ClearError_LoggedNotPanicked set clipboardPending = "x" and called copyStagedClipboard, which shelled to pbcopy and wrote "x" to the developer's real macOS clipboard on every run. TestApp_CopyToClipboard did the same with "hello". Inject the OS clipboard writer via App.clipboardWriter so tests can swap in a no-op. The production path (New() -> pbcopyWriter) is unchanged. pbcopyWriter lives in its own file so it can be cleanly excluded from the coverage gate as privileged/external-resource glue. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Drop redundant header.Notice() assertion in TestCopyToClipboard_WriterError (the goroutine never writes header on the error path, so the read was a no-op; removing it sidesteps any theoretical -race concern). - Clarify nil-panic location in App.clipboardWriter doc — the panic surfaces inside copyToClipboard's goroutine. - Update copyStagedClipboard doc to say "via the configured clipboard writer" instead of "via pbcopy" (now goes through the injection seam). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A TUI test (
TestCopyStagedClipboard_ClearError_LoggedNotPanicked) setapp.clipboardPending = "x"and calledcopyStagedClipboard(), whichshelled to
pbcopyand wrote"x"to the developer's real macOSclipboard every test run.
TestApp_CopyToClipboarddid the same with"hello".Inject the OS clipboard writer as a function field on
Appso testscan swap in a no-op:
App.clipboardWriter func(string) error, set byNew()topbcopyWriter. Production path unchanged.pbcopyWritermoved tointernal/tui/clipboard_pbcopy.goand addedto
coverage-ignore.txt(privileged/external-resource policy).TestCopyToClipboard_WriterErrorcovers the early-return branchwhen the writer fails.
App.clipboardWriterexplicitly states that testauthors who skip the override will silently clobber the real
clipboard.
Verified:
pbpastesurvivesgo test -race -count=1 ./internal/tui/unchanged across multiple consecutive runs.
Co-Authored-By: Claude noreply@anthropic.com