Filter incomplete URLs without a valid TLD from link picker#599
Merged
Conversation
The greedy URL regex matches as the agent streams output, so partial URLs like `https://gi` leaked into the link picker (TUI ctrl+l and the PWA Open-link modal). Add a `hasValidHost` check that requires an IP literal, `localhost`, or a DNS name whose final label is ≥2 chars starting with a letter — covers `.co` / `.museum` / xn--punycode while rejecting no-dot hosts, one-letter TLDs, and numeric TLDs.
Followup from review: `hasValidHost` was accepting `https://.example.com` because `LastIndexByte` found the interior dot and the TLD check passed on `com`. Reject hostnames with a leading or trailing dot before the TLD lookup. Clarified the "no dot in host" guard at the same time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The greedy URL regex matched partial URLs (
https://gi) as the agentstreamed output, leaking them into the TUI
ctrl+lpicker and the PWA"Open link" modal. Add a
hasValidHostcheck ininternal/linksthatrequires an IP literal,
localhost, or a DNS hostname whose finallabel is ≥2 chars starting with a letter — covers
.co,.museum,and
xn--*punycode while rejecting no-dot hosts, leading/trailingdots, one-letter TLDs, and numeric TLDs.
10 new test cases cover the rule. Gotcha doc updated.
Co-Authored-By: Claude noreply@anthropic.com