feat(#254): add connpass.com embed support#255
Merged
Conversation
Add support for embedding connpass.com event pages in note.com articles.
Connpass URLs use subdomain format ({group}.connpass.com/event/{id}/)
and are handled via the 'external-article' service type.
- Add CONNPASS_PATTERN regex for URL detection (excludes www subdomain)
- Register pattern in EMBED_PATTERNS with 'external-article' service
- Add comprehensive unit tests (13 test cases across 8 test classes)
- Add E2E test for API conversion verification
- Update documentation and sample embeds file
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add missing docstring section for connpass embed support following the established pattern for other embed services. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{group}.connpass.com/event/{id}/) and are handled via theexternal-articleservice typewwwsubdomainTest plan
uv run pytest tests/unit/test_embeds.py -v -k connpass)uv run pytest tests/e2e/test_embed_api.py -v -k connpass)note_create_from_fileusing sample_embeds.mdruff check,ruff format,mypy)Closes #254
🤖 Generated with Claude Code