chore: add binary#276
Open
yashsa wants to merge 4 commits into
Open
Conversation
| fi | ||
|
|
||
| # Backup existing configuration if it exists | ||
| if [ -f ~/.odin/config ]; then |
Contributor
There was a problem hiding this comment.
Execute touch ~/.odin/config.toml to avoid creating config backup etc. If config.toml exists then new odin will read/write from this file and old odin will continue using config
| echo "Downloaded the odin binary successfully." | ||
|
|
||
|
|
||
| if [ -f /usr/local/bin/odin ] && [ ! -f /usr/local/bin/old-odin ] && [ ! -f /opt/homebrew/bin/old-odin ]; then |
Contributor
There was a problem hiding this comment.
Use which odin to get existing location of odin binary instead of assuming /usr/local/bin/odin and opt/homebrew/bin/odin
| sudo mv /opt/homebrew/bin/odin /opt/homebrew/bin/old-odin | ||
| fi | ||
|
|
||
| sudo mv ./odin /usr/local/bin/ |
Contributor
There was a problem hiding this comment.
Move new odin also to same path as existing odin
| @@ -0,0 +1,130 @@ | |||
| #!/bin/bash | |||
| set -e | |||
Contributor
There was a problem hiding this comment.
We need to remove -e, enabling this will exit the script on errors due to which
if [ $? -ne 0 ]; thenbecomes meaningless
Signed-off-by: surajgour-d11 <suraj.gour@dream11.com>
surajgour-d11
force-pushed
the
chore/add-binary
branch
from
2ffca40 to
187743b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Odin version(x.y.z)
Features
Resources