Skip to content

[DEV] 파비콘 및 메타 태그 설정#138

Merged
drddyn merged 2 commits into
developfrom
dev/pavicon
May 25, 2026
Merged

[DEV] 파비콘 및 메타 태그 설정#138
drddyn merged 2 commits into
developfrom
dev/pavicon

Conversation

@drddyn

@drddyn drddyn commented May 25, 2026

Copy link
Copy Markdown
Owner

🔗 관련 이슈

close #137

✨ 요약

파비콘을 추가했습니다
메타 태그를 추가했습니다

@vercel

vercel Bot commented May 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
mine Ready Ready Preview, Comment May 25, 2026 4:14pm

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the index.html file to set the language to Korean, adds comprehensive Open Graph metadata for social sharing, and introduces a new SVG favicon. Review feedback identifies the accidental removal of the critical viewport meta tag, a typo in the og:image URL, and inconsistent indentation. Additionally, it is recommended to use the standard rel="icon" attribute and consider using PNG or JPG formats for OG images to ensure better compatibility across social platforms.

Comment thread Mine/index.html Outdated
Comment thread Mine/index.html Outdated
Comment thread Mine/index.html
@drddyn drddyn self-assigned this May 25, 2026
@drddyn drddyn merged commit 02f9031 into develop May 25, 2026
3 checks passed
@drddyn drddyn deleted the dev/pavicon branch May 25, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DEV] og 태그, 파비콘 추가

1 participant