Fix Apple touch icons for each skin - #519
Open
jimmeak wants to merge 1 commit into
Open
Conversation
Use the right SVG, ICO and Apple touch icon formats for each skin, and handle the standard root touch icon URLs.\n\nFixes dracidoupe#505
jimmeak
marked this pull request as ready for review
July 14, 2026 22:05
Almad
reviewed
Jul 18, 2026
|
|
||
| self.assertEquals("/", res.url) | ||
|
|
||
| def test_page_uses_correct_favicon_formats_for_each_skin(self): |
Member
There was a problem hiding this comment.
have you been writing those tests or is it LLM? I don't think iterations like this make sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The page was using the ICO file for everything and marking it as SVG. This gives each skin a proper SVG favicon, ICO fallback and 180×180 PNG touch icon.
The usual
/apple-touch-icon.pngand precomposed URL now redirect to the icon for the current skin too. I added tests for all three skins and both redirect URLs.The full test suite and Ruff pass locally.
Fixes #505