Link news authors to their profiles - #518
Open
jimmeak wants to merge 1 commit into
Open
Conversation
Known news authors now point to their user profile. Historical names without a matching profile stay as plain text instead of a broken link.\n\nFixes dracidoupe#117
jimmeak
marked this pull request as ready for review
July 14, 2026 18:31
Almad
requested changes
Jul 18, 2026
| </div> | ||
| <footer> | ||
| <a href="#" class="author" rel="author">{{ n.author }}</a> | ||
| {% with author_url=n.author|nick_url %} |
Member
There was a problem hiding this comment.
Could you please add author_url as a method on News object instead? That will be quite a bit cleaner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
News authors currently point to
#, even when the author has a profile. This links known authors to their profile and leaves old or unmatched names as plain text instead of a broken link.I added tests for both cases. The full test suite and Ruff pass locally.
Fixes #117