Link newsfeed comments to their location - #517
Open
jimmeak wants to merge 2 commits into
Open
Conversation
Give creation comments stable anchors and include the correct comment page in their URLs. Fixes dracidoupe#348
Use the lowercase model name stored by production creative pages so the detail template resolves consistently in the full suite.
jimmeak
marked this pull request as ready for review
July 14, 2026 10:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments in the newsfeed currently open just the article, so it can take a while to find the actual comment. This adds an anchor to each comment and links to the right comment page, including older comments that ended up on another page.
I added tests for the newsfeed link, the comment anchor, and page 2 links. The full test suite and Ruff pass locally.
Fixes #348