Use POST forms for tavern bookmarks (#310) - #516
Merged
Almad merged 1 commit intoJul 18, 2026
Conversation
Replace state-changing bookmark links with CSRF-protected forms and validate bookmark actions from POST data. Preserve the existing link appearance and cover mutation, validation, and rendering behavior.\n\nFixes dracidoupe#310.
jimmeak
marked this pull request as ready for review
July 14, 2026 09:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bookmark/unbookmark link changes data through GET, which browsers can prefetch. This switches it to a small POST form instead.
I kept the button looking like the old link and added checks for bookmarking, unbookmarking, bad actions, GET requests and CSRF.
Tests and Ruff pass locally, and the GitHub checks are green too.
Fixes #310.