Preserve query parameters when changing skin (#252) - #515
Open
jimmeak wants to merge 2 commits into
Open
Conversation
URL-encode the nested redirect target in skin-switch links so pages with multiple query parameters return to the complete original URL. Add an authenticated rendering regression test.\n\nFixes dracidoupe#252.
jimmeak
marked this pull request as ready for review
July 14, 2026 08:20
Member
|
oh please just merge master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the skin could lose some query parameters from the current page, so you could end up somewhere else than expected. This URL-encodes the redirect value before putting it into the skin links.
I changed both menu variants and added a test with multiple query parameters. Tests, Ruff and the GitHub checks are green.
Fixes #252.