Polish import/settings UI and fix Share Importer composer#207
Merged
Conversation
- Settings: replace custom logged-out sign-in button with standard ApproachNoteButton, relabel "Sign In / Sign Up" - Import Song shelf (iOS + macOS): drop icon and grey card, de-emphasize MusicBrainz ID, widen fields to full width - Create Song form (iOS + macOS): remove MusicBrainz ID field and the Additional Details section, move Cancel below Create Song, use standard ApproachNoteButton styling; drop unused `key` state - Share Importer JS: resolve composers via the MusicBrainz web service (artist-rels) instead of brittle DOM scraping, with a DOM fallback and a one-shot async completion guard Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UI polish across the import/settings flows plus a fix for composer data not coming through when importing a song from MusicBrainz via the Share Importer.
Settings (logged-out)
ApproachNoteButton(no icon, primary styling); relabel to Sign In / Sign Up so it fits on one line.Import Song shelf (iOS + macOS share extensions)
Create Song form (iOS + macOS)
ApproachNoteButtonstyling.keystate var. (Importedmusicbrainz_id/work_typeare still submitted to the API.)Share Importer composer fix
The composer was never being scraped: on a MusicBrainz work page, composer is a relationship (
<dt>composer:</dt><dd>…), not a classed sidebar property, so the olddd.composer/dd.writerselectors never matched. The work page is now also served behind a JS challenge, making DOM scraping unreliable./ws/2/work/{id}?inc=artist-rels&fmt=json, same-origin) instead of the DOM.composer, fall back towriter/lyricist.completionFunctionto fire exactly once, with a 4s timeout safety net.Test plan
227437b0-…) and confirm composer populates as Jackie McLean (log should showcomposer = 'Jackie McLean').🤖 Generated with Claude Code