Adopt spacing tokens across Mac views (#201)#206
Merged
Conversation
Value-preserving spacing-token sweep across apps/Mac, mirroring the iOS #199 transform (only `spacing:` and `.padding(...)` numeric args): on-scale 4/8/12/16/20/24 renamed to spacing* tokens, off-scale content gaps snapped (2->spacingXXS, 6->spacingXS, 10->spacingXS). Decorative/component insets (badge .padding(6/2), PageDots vertical 6) and large page-level values are left as literals. Now that #202 and #204 have landed, this covers all Mac views including SongDetailView, RecordingCard, and RecordingDetailView (previously deferred to avoid a merge collision with that work). Also reconcile PerformerDetailView with SongDetailView: align section spacing to spacingMD and hide the duplicate macOS sort-menu disclosure chevron. Closes #201. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-lands the #201 Mac spacing-token sweep. This was originally bundled into PR #205 but did not make it into that squash-merge (it was pushed after the squash captured the branch), so it's being landed cleanly here off the current
main.Now that #202 and the SongDetailView parity (#204) have merged, this sweep also covers
SongDetailView,RecordingCard, andRecordingDetailView— which were deferred earlier to avoid colliding with that work.What it does
apps/Mac(onlyspacing:and.padding(...)numeric args), mirroring the iOS bring all views into conformance with the updated layout.md spec #199 transform:4/8/12/16/20/24→ApproachNoteTheme.spacing*2→spacingXXS,6→spacingXS,10→spacingXS.padding(6/2), PageDots vertical 6) and large page-level values left as literalsPerformerDetailViewwithSongDetailView: section spacing →spacingMD, and hides the duplicate macOS sort-menu disclosure chevron.28 files changed, symmetric diff (+274/−272).
Testing
ApproachNoteMacscheme builds green (macOS, code signing disabled).Closes #201.
🤖 Generated with Claude Code