Resolve button/toast off-scale padding (#202)#203
Merged
Conversation
Button keeps its 14pt vertical padding but via a new ApproachNoteTheme.controlVerticalPadding token, semantically distinct from the spacing scale (sizes the control's tap target, not rhythm). ToastView snaps to spacingMD (16) since its padding is card breathing room rather than a tap target. Documented both in doc/design/layout.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the button / toast vertical padding slice of #202 (the
14pt off-scale value used byApproachNoteButtonandToastView).Decision
Per-component, since the two share the value but not the intent:
ApproachNoteTheme.controlVerticalPaddingso the off-scale value reads as intentional rather than a stray literal. It sizes the pill's tap-target height, not inter-element rhythm, so it deliberately sits outside the spacing scale (betweensm=12 andmd=16). No visual change.spacingMD(16). Its padding is card breathing room, not a tap target, so it belongs on the scale. Toast card is ~4pt taller (2pt top + bottom).Changes
ApproachNoteTheme.swift— newcontrolVerticalPaddingtoken in a separate, documented "component metrics" extensionApproachNoteButton.swift— adopt the tokenToastView.swift—14→spacingMDdoc/design/layout.md— document the off-scale exception and the toast decision🤖 Generated with Claude Code