[SD-1781] document embed date

[lambry]

JIRA issue: https://digital-vic.atlassian.net/browse/SD-1781

Changed

1. Get's the display updated date option on embeds working again, also removes an old local patch that wasn't used anyway.

Notes:

• Looks like the entity_embed module doesn't repect the allowed HTML list, this means the custom data attribute we add data-show-last-updated is stripped out, there used to be a patch to fix this in an older version of entity_embed but it was removed in this PR removed entity embed patchs #585
• However the patch is still needed for this to work, there's an open PR that would resolve the issue but it's been sitting there for two years https://git.drupalcode.org/project/entity_embed/-/merge_requests/31, also for reference here's the related issue on drupal.org https://www.drupal.org/project/entity_embed/issues/3410132
• This way of patching is a bit foreign to me, but I've copied how all the other patches are done i.e. referencing a patch file uploaded on the issue itself, the file isn't linked to a comment it's just uploaded to the issue (anyone now if that's a problem?).

Testing

BE: https://nginx-php.pr-1989.content-vic.sdp4.sdp.vic.gov.au/site-4/document-embed
FE: https://app.pr-1385.vic-gov-au.sdp4.sdp.vic.gov.au/document-embed

[waitingallday]

LGTM but I will leave the actual review to @vincent-gao or @anthony-malkoun 🙏

[vincent-gao]

LTGM

[vincent-gao]

Oh, the build failed. Looks like Drupal doesn't like this patch.

[vincent-gao]

the build failed.

[lambry]

the build failed.

Yeah, looking at that now. Cheers

[lambry]

@vincent-gao, I think it's a new line issue, just tried to upload a new patch and Drupals telling me I need to wait 7200 seconds i.e. 2 hours before submitting the form again. 😬

[vincent-gao]

LGTM!