Skip to content

[SD-1485] Refined site section validation#781

Merged
vincent-gao merged 10 commits into
developfrom
SD-1485-site-section-validation
Jun 25, 2026
Merged

[SD-1485] Refined site section validation#781
vincent-gao merged 10 commits into
developfrom
SD-1485-site-section-validation

Conversation

@vincent-gao

@vincent-gao vincent-gao commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Jira

https://digital-vic.atlassian.net/browse/SD-1485

Changes

Adds coupling between field_node_primary_site and field_node_site on node forms. JS handles the UI part, PHP handles backend validation only. Implemented inside the existing tide_site_restriction_field_widget.

Images

CleanShot 2026-06-02 at 15 28 46
CleanShot.2026-06-02.at.15.31.21.mp4

Refactor

@vincent-gao vincent-gao changed the title Sd 1485 site section validation [SD-1485] Refined site section validation Jun 2, 2026
@vincent-gao vincent-gao marked this pull request as ready for review June 2, 2026 05:33
@vincent-gao vincent-gao self-assigned this Jun 2, 2026
@github-actions

Copy link
Copy Markdown

@anthony-malkoun
This PR has been open for 7 days - please review and merge ASAP.

@anthony-malkoun

Copy link
Copy Markdown

Given how this behaves, should we just hide the primary site field?

@vincent-gao

Copy link
Copy Markdown
Contributor Author

Given how this behaves, should we just hide the primary site field?

Hi @anthony-malkoun This ticket's SD/AC doesn't cover hiding field_node_primary_site.

what do you mean by

hide the primary site field?

Are you saying hide it and presave the value?
Even if we went the "hide the field + populate it via a presave hook" route, we would still need to first define what the "primary site" actually is. Our and QA test cases also depend on a primary site being set. I think.

We might need some time to look into the feasibility.

@anthony-malkoun anthony-malkoun left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking me through this @vincent-gao. Approved.

@vincent-gao vincent-gao merged commit 3c21823 into develop Jun 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants