Skip to content

Handle debugger attributes in ILTrim#128357

Draft
Copilot wants to merge 4 commits into
mainfrom
copilot/add-debugger-display-and-proxy-handling
Draft

Handle debugger attributes in ILTrim#128357
Copilot wants to merge 4 commits into
mainfrom
copilot/add-debugger-display-and-proxy-handling

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 19, 2026

Description

ILTrim did not model DebuggerDisplayAttribute or DebuggerTypeProxyAttribute, so debugger-driven metadata roots diverged from illink.

  • Debugger attribute graph roots

    • Add dependency handling for DebuggerDisplayAttribute and DebuggerTypeProxyAttribute.
    • Preserve debugger-referenced members when KeepMembersForDebugger is enabled.
    • Apply illink-compatible fallback behavior for unresolved display expressions.
  • Assembly-level targets

    • Add conditional dependencies from assembly-level debugger attributes to their target types.
    • Resolve Target, TargetTypeName, and proxy type references in the correct module context.
  • Expected failures

    • Remove ILTrim expected-failure entries for debugger-related cases that now pass.

Copilot AI and others added 4 commits May 18, 2026 09:19
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/a9ea79c3-4625-4133-bb2e-63b3a23db064

Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/a9ea79c3-4625-4133-bb2e-63b3a23db064

Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/a9ea79c3-4625-4133-bb2e-63b3a23db064

Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/a9ea79c3-4625-4133-bb2e-63b3a23db064

Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 19, 2026 04:09
Copilot AI review requested due to automatic review settings May 19, 2026 04:09
@MichalStrehovsky MichalStrehovsky added area-Tools-ILLink .NET linker development as well as trimming analyzers and removed area-Diagnostics-coreclr labels May 19, 2026
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @agocke, @dotnet/illink
See info in area-owners.md if you want to be subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Tools-ILLink .NET linker development as well as trimming analyzers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants