[cDAC]: convert DacDbi GetRcwCachedInterfacePointers to EnumerateRcwCachedInterfacePointers and implement in cDAC#128341
Merged
Conversation
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR converts the DAC/DBI RCW cached interface pointer query from an array-returning API to a callback-based enumeration API and adds the cDAC implementation path.
Changes:
- Replaces
GetRcwCachedInterfacePointerswithEnumerateRcwCachedInterfacePointersacross DAC/DBI interface definitions and consumers. - Implements cDAC RCW interface pointer enumeration using
IBuiltInCOM.GetRCWInterfaces. - Adds a reusable DI-side
CallbackAccumulator<T>helper and applies it to heap segment and RCW interface pointer enumeration.
Show a summary per file
| File | Description |
|---|---|
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs |
Updates the managed DAC/DBI interface signature to the callback-based RCW enumerator. |
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs |
Adds the cDAC implementation for enumerating RCW cached interface pointers. |
src/coreclr/vm/runtimecallablewrapper.h |
Removes the old RCW helper that built an array of cached interface pointers. |
src/coreclr/inc/dacdbi.idl |
Updates the IDL contract with the new callback typedef and method. |
src/coreclr/debug/inc/dacdbiinterface.h |
Updates the native DAC/DBI interface declaration and comments. |
src/coreclr/debug/di/rspriv.h |
Adds the reusable callback accumulator helper. |
src/coreclr/debug/di/process.cpp |
Refactors heap segment enumeration to use CallbackAccumulator<T>. |
src/coreclr/debug/di/divalue.cpp |
Updates ICorDebugComObjectValue::GetCachedInterfacePointers to consume the new callback-based DAC API. |
src/coreclr/debug/daccess/dacdbiimpl.h |
Updates the DAC implementation declaration. |
src/coreclr/debug/daccess/dacdbiimpl.cpp |
Implements native callback-based RCW interface pointer enumeration. |
Copilot's findings
- Files reviewed: 10/10 changed files
- Comments generated: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetRcwCachedInterfacePointerstoEnumerateRcwCachedInterfacePointers