Fix exit code handling in GetCompletions method to ensure correct res…#2807
Open
AhmedMyoussif wants to merge 2 commits into
Open
Fix exit code handling in GetCompletions method to ensure correct res…#2807AhmedMyoussif wants to merge 2 commits into
AhmedMyoussif wants to merge 2 commits into
Conversation
jonsequitur
reviewed
May 20, 2026
| { | ||
| result = readToEndTask.Result; | ||
| } | ||
| result = readToEndTask.Result; |
Contributor
There was a problem hiding this comment.
This line should now be removed.
Author
There was a problem hiding this comment.
Done! Thank you for catching it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2137
Summary of Changes
StreamReaderviaReadToEndAsync().process.WaitForExit(timeout)to ensure that the process and any potential grandchild processes completely close and flush their pipes, addressing the race conditions / thread-safety concerns mentioned in SuggestionStore::GetCompletions to check exit code of invoked applica… #2160.process.ExitCode == 0before assigning the suggestions to the result string.