Remove misplaced pure annotations#66778
Open
TheAlexLichter wants to merge 1 commit into
Open
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Thanks for your PR, @TheAlexLichter. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes misplaced /*#__PURE__*/ annotations from private helper function declarations in the SignalR TypeScript client to avoid downstream bundler INVALID_ANNOTATION warnings, without changing helper behavior.
Changes:
- Removed
/*#__PURE__*/annotations and the associated eslint suppression fromgetOsNameandgetRuntimeVersionhelper declarations. - Kept the helper implementations and call sites unchanged.
TheAlexLichter
force-pushed
the
remove-signalr-misplaced-pure-annotations
branch
from
7aef69e to
1b96b6e
Compare
TheAlexLichter
changed the title
pure annotations
TheAlexLichter
changed the title
pure annotationspure annotations
|
there is also a related issue: #55286 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes invalid
/*#__PURE__*/comments from private helper function.These annotations only apply to call/new expressions, so they are ignored in this position and can produce
INVALID_ANNOTATIONwarnings in downstream bundlers.Resolves #55286
See also rolldown/rolldown#9496