Fix VS target hook points in Arcade SDK#16890
Merged
Merged
Conversation
Regressed with ea5fa16 Use standard hook points that are called by Build.proj (when invoking AfterSigning.proj) instead of these cutom ones.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression in the Arcade SDK Visual Studio insertion pipeline by switching MSBuild target hook points to ones that are actually invoked by Build.proj during the AfterSigning.proj phase.
Changes:
- Run
GenerateVisualStudioInsertionManifestsbeforePack(instead of beforeAfterPack) so it triggers in theAfterSigning.projphase. - Run
_BuildTrainingInputsbeforePack(instead of beforeAfterBuild) so IBC training inputs are generated during theAfterSigning.projphase.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.DotNet.Arcade.Sdk/toolset/VisualStudio.InsertionManifests.targets | Updates manifest generation to hook into Pack, ensuring it runs when AfterSigning.proj is invoked by Build.proj. |
| src/Microsoft.DotNet.Arcade.Sdk/toolset/VisualStudio.BuildIbcTrainingInputs.targets | Updates IBC training input generation to hook into Pack, ensuring it runs in the expected AfterSigning.proj execution flow. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
akoeplinger
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regressed with ea5fa16
Use standard hook points that are called by Build.proj (when invoking AfterSigning.proj) instead of these cutom ones.
To double check: