JobMonitor: emit failed work item errors as Azure DevOps task.logissue entries

[Copilot]

Failed Helix work item details were previously easy to miss in Azure DevOps timeline issue surfacing. This change now emits explicit Azure DevOps error issue commands (##vso[task.logissue type=error]) for failed work items (including console links), while preserving error-level logging.

To double check:

• Problem addressed

  • Failed work item console-link output is now emitted in Azure DevOps issue-command format so it is surfaced in timeline errors.

• Code changes

  • /src/Microsoft.DotNet.Helix/JobMonitor/JobMonitorRunner.cs
    • LogFailedWorkItemConsoleLinks(...) now writes failed work item messages to stderr using:
      • ##vso[task.logissue type=error]❌ Work item ...
      • ##vso[task.logissue type=error]Console: ...
    • Keeps corresponding LogError(...) output aligned with the same format.
  • /src/Microsoft.DotNet.Helix/Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests/JobMonitorRunnerTests.cs
    • Updated CompletedHelixJob_LogsFailedWorkItemConsoleLinks to validate error messages contain ##vso[task.logissue type=error].

• Example

  Console.Error.WriteLine($"##vso[task.logissue type=error]❌ Work item '{workItem.Name}' in job '{helixJob.DisplayName}' failed ({state}).");
  Console.Error.WriteLine($"##vso[task.logissue type=error]Console: {consoleOutputText}");

• The right tests are in and the right validation has happened. Guidance: https://github.com/dotnet/arcade/blob/main/Documentation/Validation.md

[premun]

@copilot the timeline still doesn't have the error about the failed work item. Maybe you need to use the ##[error] notation (or how is it exactly)?

[Copilot]

Pull request overview

This PR improves Helix JobMonitor diagnostics in Azure DevOps by emitting failed work item console-link details at error level so they surface in timeline error reporting, rather than being easy-to-miss informational output.

Changes:

• Promoted per-failed-work-item console-link logging from LogInformation to LogError.
• Updated the test logger to capture error-level messages and added an assertion verifying the failed work item message is logged as an error.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/Microsoft.DotNet.Helix/JobMonitor/JobMonitorRunner.cs	Logs failed work item console links via LogError to improve visibility in Azure DevOps timeline error surfacing.
src/Microsoft.DotNet.Helix/Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests/JobMonitorRunnerTests.cs	Extends the recording logger to track error messages and asserts the failure console-link output is emitted at error level.

[Copilot]

@copilot the timeline still doesn't have the error about the failed work item. Maybe you need to use the ##[error] notation (or how is it exactly)?

Addressed in 8ab2acf. Failed work items now emit explicit Azure DevOps error lines using ##[error] (for both the failure summary line and the console-link line), and tests were updated to assert those lines are written.

[mmitche]

@copilot Validate that the error messages contain: '##vso[task.logissue type=error]'

[Copilot]

Updated in 967c155 and 9b337ee. The failed work item error assertions now validate ##vso[task.logissue type=error], and the monitor now writes those task.logissue error lines directly to stderr for Azure DevOps parsing.

[mmitche]

When writing the error, you need to put in '##vso[task.logissue type=error]'. to get it to show in the timeline.