Remove dnceng-symbol-server-pat from publish-logs.yml redaction list#16868
Merged
Conversation
The PAT is no longer used for symbol upload authentication since PR #16688 migrated to DefaultIdentityTokenCredential (Entra auth). The redaction entry is no longer needed. Relates to: dnceng/internal#10150
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the dnceng-symbol-server-pat entry from the sensitive-token list passed to the post-build log/binlog redaction step (publish-logs.yml), as follow-up cleanup after migrating symbol publishing authentication away from PATs.
Changes:
- Removed
$(dnceng-symbol-server-pat)from the arguments passed toeng/common/post-build/redact-logs.ps1.
Remove the secret manifest entry so the PAT is no longer provisioned to EngKeyVault. This addresses the defense-in-depth concern: removing both the source (vault config) and the redaction entry together ensures the token cannot leak in binlogs.
Member
Author
|
Addressed the review feedback: added a second commit that removes the |
Open
3 tasks
hoyosjs
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the \dnceng-symbol-server-pat\ entry from the binlog redaction list in \�ng/common/core-templates/steps/publish-logs.yml.
Motivation
PR #16688 migrated symbol upload authentication from PAT-based auth to \DefaultIdentityTokenCredential\ (Entra). The PAT is no longer functionally used for symbol publishing. This cleanup removes the now-unnecessary redaction entry.
Changes
edact-logs.ps1\ arguments in \publish-logs.yml\
Related