[release/10.0.1xx] Emit NETSDK1202 EOL warning for net9.0-android projects#11349
Open
jonathanpeppers wants to merge 3 commits into
Open
[release/10.0.1xx] Emit NETSDK1202 EOL warning for net9.0-android projects#11349jonathanpeppers wants to merge 3 commits into
jonathanpeppers wants to merge 3 commits into
Conversation
Add an EolWorkload item for net9.0-android so the .NET SDK emits the NETSDK1202 warning when building projects targeting net9.0-android, which has reached end-of-life. See: dotnet/sdk#32426 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The NETSDK1202 EOL warning causes AssertHasNoWarnings to fail for net9.0-android. Disable the EOL workload check in the test since we are intentionally testing with the EOL TFM. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
force-pushed
the
jonathanpeppers/eol-warning-net9-android
branch
from
24bc92f to
751db01
Compare
jonathanpeppers
added
the
ready-to-review
Contributor
There was a problem hiding this comment.
Pull request overview
Adds .NET SDK EOL workload metadata so net9.0-android projects on release/10.0.1xx emit NETSDK1202 as a warning, while adjusting an existing SDK test to avoid failing on the new warning.
Changes:
- Adds
EolWorkloadmetadata fornet9.0-android. - Suppresses EOL workload checking in an existing no-warnings test path for net9 Android.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Xamarin.Android.Build.Tasks/Microsoft.NET.Sdk.Android/WorkloadManifest.in.targets |
Adds the EOL workload item that triggers NETSDK1202 for net9 Android projects. |
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/XASdkTests.cs |
Disables EOL workload checks for net9 in an existing test that asserts no warnings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
EolWorkloaditem fornet9.0-androidso the .NET SDK emits the NETSDK1202 warning when building projects targetingnet9.0-android, which has reached end-of-life.This leverages the mechanism introduced in dotnet/sdk#32426.
Note
This change is only needed on
release/10.0.1xx. Onmain(net11),net9.0-androidprojects already receive a hard error viaEol.targets(which imports for TFV ≤ 8.0 — and net9 will be added to that gate in a future release). Onrelease/10.0.1xx, the net9 SDK is still functional, so we emit a warning rather than an error to give developers time to migrate.