fix(pwsh): repair profile load tracer — empty-List truthiness swallow…#74
Merged
Conversation
…ed the trace
Two PowerShell collection-semantics bugs left DOTFILES_PROFILE_TRACE=1 with no
table:
- `$x = if (...) { [List]::new() }` emits the empty list through the pipeline,
which enumerates it to nothing, so $global:DotfilesTrace ended up $null.
Assign the List directly via if/else instead.
- Add-DotfilesTrace guarded with `if ($global:DotfilesTrace)`, but an empty
List is falsy in PowerShell, so the first .Add() never fired and the list
stayed empty forever. Use an explicit `$null -ne` check.
With both fixed, the sorted load-trace table prints as intended.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes the PowerShell profile “load tracer” so DOTFILES_PROFILE_TRACE=1 reliably produces the intended sorted trace table by correcting two PowerShell collection/truthiness edge cases.
Changes:
- Replaces an
if-expression assignment that unintentionally pipeline-enumerated an emptyList(yielding$null) with an explicitif/elseassignment. - Updates
Add-DotfilesTraceto use an explicit$null -necheck so an emptyListdoesn’t evaluate as falsy and block the first.Add()call.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ed the trace
Two PowerShell collection-semantics bugs left DOTFILES_PROFILE_TRACE=1 with no table:
$x = if (...) { [List]::new() }emits the empty list through the pipeline, which enumerates it to nothing, so $global:DotfilesTrace ended up $null. Assign the List directly via if/else instead.if ($global:DotfilesTrace), but an empty List is falsy in PowerShell, so the first .Add() never fired and the list stayed empty forever. Use an explicit$null -necheck.With both fixed, the sorted load-trace table prints as intended.