build(deps): bump requests from 2.32.4 to 2.33.0 in /packages/clip-processor-py#597
Open
dependabot[bot] wants to merge 23 commits into
Open
build(deps): bump requests from 2.32.4 to 2.33.0 in /packages/clip-processor-py#597dependabot[bot] wants to merge 23 commits into
dependabot[bot] wants to merge 23 commits into
Conversation
The dota job duplicated the services matrix job's buildx/login/build steps, and every job computed 5-7 granular *_changed outputs that only ever fed one OR condition repeated across four steps. Collapse to a single build matrix (dota becomes a 4th entry with an extended paths regex) gated on one should_build grep. 165 -> 75 lines, identical build/push/tag/label behavior. Verified change-detection equivalence exhaustively: all 4096 changed-file category combinations produce the same per-service build decision as before. Also adds fail-fast: false so one service's failure no longer cancels others.
The minimap-blocker overlay is unused in production, but minimapParser.init ran on every GSI tick for any beta_tester with the setting on — parsing entity positions and serializing them over socket.io to nobody. Comment out the per-tick block (and its now-unused import) so the work is skipped; uncomment to revive. emitMinimapBlockerStatus (connect/event-driven, not per-tick) is left intact.
Image builds were cold every run: the bake set overrode cache with empty *.cache-from=/*.cache-to=, while docker-compose.yml still declared registry cache refs the workflow ignored. The earlier GHA-cache attempt failed only because it shared one scope across all services (scope=github.workflow), so they clobbered each other (~0% hits). Use type=gha scoped per matrix.service with mode=max (the bun install lives in an intermediate stage, so mode=max is required to cache it). Remove the unused x-bake registry cache blocks from compose so config matches reality. The 4 stale ghcr cache-* packages were deleted separately.
builder.yml: replace the dual hand-maintained path lists + last-commit-only git diff with a single dorny/paths-filter pre-job that diffs the full push range. Fixes two rebuild-skip bugs: multi-commit pushes where an earlier commit touched a service, and root package.json/bun.lock changes that previously rebuilt only dota. The build matrix is now derived from the filter output, so only changed services spin up runners. Add concurrency groups to builder.yml and ci.yml so superseded runs on a branch are cancelled. Pin CI/health-check Bun to 1.3.14 to match the prod image. Drop the unused profanity-filter Dockerfile.
A stale socket closing after a reconnect handoff clobbered the live connection's status flag, so uptime monitors reported "disconnected" while events kept flowing. twitch-chat now ignores closes from non-current sockets and treats keepalives/notifications as liveness; twitch-events derives connectedness from a connected-client count instead of a clobberable boolean (and drops dead client-only socket handlers).
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
These commands still return real results, so the appended Oct 9 explainer is no longer needed.
Add offline tests across api_server (HTTP routes, image-serving security, auth, stuck-request reset, stream requests), postgresql_client (match/draft fetch, queue state, facet merge), dota_heroes helpers, clip_utils URL/error paths, stream_processor state + backoff, and facet_detection seams. Five tests fail intentionally to pin real bugs for follow-up: - get_clip_result(_by_match_id) swallows a facets/player KeyError and returns None, silently invalidating an otherwise-valid cached result. - extract_clip_id returns "" (not None) for path-bearing junk URLs, which can collide as a cache/queue-dedup key.
- get_clip_result(_by_match_id): guard facet merge with facets.get(team, []) and skip players/heroes missing team/position, so a partial or legacy facets payload no longer raises a swallowed KeyError that discarded the whole cached result and forced needless reprocessing. - extract_clip_id: drop empty path segments so path-bearing junk URLs return None instead of "", which could collide as a cache/queue-dedup key. Turns the five intentionally-failing tests from the prior commit green.
…, and dota Wire up test infra (bunfig + test script + test:all) for twitch-events and twitch-chat, which previously had no tests, and add offline/mocked suites: - twitch-events: RateLimiter, isAuthenticated, runSubscriptionHealthCheck - twitch-chat: handleChatMessage/sendTwitchChatMessage, bet/poll transforms - shared-utils: conduitManager fetch/retry/cache - dota: ranks math, subscription gating, and 27 chat commands All suites run fully offline with zero skipped tests.
The facet-merge guards were copy-pasted verbatim across get_clip_result and get_clip_result_by_match_id, so a future change had to be applied twice or silently diverge. Extract a single _merge_facets_into_result helper used by both. Also hoist the duplicated FakePortrait test double into a shared _recording_portrait() helper.
Add a MongoDBSingleton mock to the twitch/lib test harness whose delayedGames findOne returns a controllable state.delayedGame, unlocking the match-data commands that read live game info from Mongo.
- assert real source constants (DBSettings, LOBBY_TYPE_RANKED) instead of literals - distinguish ranked yes/no by message content rather than just reply count - make the RateLimiter reset-wait test deterministic via a patched timer - reset the handleChat dedupe cache between tests to prevent cross-test leakage
Draft alignment: the token-overlap match path was dead code -- tokens were
split from the already space-stripped normalized name, collapsing multi-word
names to a single token. Word-swapped names ("Team Liquid" / "Liquid Team")
fell below the difflib ratio threshold and went unmatched. Tokenize the raw
name (normalizing each word) so token overlap works as documented.
Queue dedup: a brand-new enqueue returns status 'pending', so it tripped the
"already in the processing queue" branch -- giving a misleading message AND
skipping start_worker_thread(). add_to_queue now flags real dedup hits with
'deduplicated', and the clip/stream paths branch on that instead of status.
With ENABLE_SPECTATE_FRIEND_GAME off, the non-spectator path returns the Valve-disabled message before any Redis/steam call, so these cover notPlaying, gameNotFound, the Valve-disabled branch, and alias routing without new mocks.
geo short-circuits to the Valve-disabled message before getAccountsFromMatch, so its reachable paths are fully covered. gm/np/smurfs/lg only reach getAccountsFromMatch (owned by gsiMocks) after an early steam32Id guard, so we cover that collision-safe branch via a parametrized loop.
Bumps [requests](https://github.com/psf/requests) from 2.32.4 to 2.33.0. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.32.4...v2.33.0) --- updated-dependencies: - dependency-name: requests dependency-version: 2.33.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps requests from 2.32.4 to 2.33.0.
Release notes
Sourced from requests's releases.
Changelog
Sourced from requests's changelog.
Commits
bc04dfdv2.33.066d21cbMerge commit from fork8b9bc8fMove badges to top of README (#7293)e331a28Remove unused extraction call (#7292)753fd08docs: fix FAQ grammar in httplib2 example774a0b8docs(socks): same block as other sections9c72a41Bump github/codeql-action from 4.33.0 to 4.34.1ebf7190Bump github/codeql-action from 4.32.0 to 4.33.00e4ae38docs: exclude Response.is_permanent_redirect from API docs (#7244)d568f47docs: clarify Quickstart POST example (#6960)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.